Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New designer should handle query parameter conversion #6256

Open
DevArjun23 opened this issue Dec 13, 2024 · 0 comments · May be fixed by #6269
Open

New designer should handle query parameter conversion #6256

DevArjun23 opened this issue Dec 13, 2024 · 0 comments · May be fixed by #6269
Assignees

Comments

@DevArjun23
Copy link
Member

DevArjun23 commented Dec 13, 2024

The swagger for features shows it is of type "array," as validated by the designer, but it missed one detail: it has "collectionFormat": "csv". This specifies how multiple values for an array parameter are serialized when making a request. For csv, the values are joined with commas (e.g., features=barcodes,formulas).

I will let you determine how UX should support users in adding one or multiple values for "features." Ultimately, these values need to be converted into a string of comma separated values in the workflow definition. This will ensure that the swagger, designer, and backend work together seamlessly to provide a better user experience.

When we moved to the new designer, we implemented/enabled the validations based on swagger, but didn't consider the collectionFormat in it before showing the UX validation error. This caused regression.

Related issues: Azure/logicapps#1202

What type of Logic App Is this happening in?

Standard (Portal)

Which operating system are you using?

Windows

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

Yes

Workflow JSON

{
        "actions": {            "Analyze_Document_for_Prebuilt_or_Custom_models_(v3.x_API)": {                "runAfter": {},                "type": "ApiConnection",                "inputs": {                    "host": {                        "connection": {                            "name": "@parameters('$connections')['formrecognizer-1']['connectionId']"                        }                    },                    "method": "post",                    "path": "/documentModels/@{encodeURIComponent('Test')}:analyze",                    "queries": {                        "api-version": "2023-07-31",                        "features": [                            "test"                        ]                    }                }            }        },
}

Screenshots or Videos

No response

Browser

  • Edge

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants