Unable to package solution using v3 createsolution.ps1

[ashwinvenkatesha]

Describe the bug
Unable to package solution using v3 createsolution.ps1

To Reproduce
After adding playbook content

1. Am running createSolution.ps1 with data path as input
   /Users/<username>/Azure-Sentinel/Solutions/IllumioSaaS/data

This leads to,
Generating Playbook using Playbooks/Illumio-Port-Blocking-Switch/azuredeploy.json
Error occured in catch of createSolutionV3 file Error details are Exception calling "Add" with "2" argument(s): "Value cannot be null. (Parameter 'key')"

Expected behavior
Solution package should work as expected.

[v-visodadasi]

Hi @ashwinvenkatesha , Thanks for flagging this issue, we will investigate this issue and get back to you with some updates. Thanks!

[ashwinvenkatesha]

https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/common/commonFunctions.ps1#L1047
this line seems like the culprit, I changed that to
if($IsFunctionAppResource)
and now solution zip is building.
However, the content built for playbooks is incorrect
Here is an example,
"name": "[[variables('hostingPlanName')]", "location": "[[variables('location')]",
The braces are not balanced anymore.

This is holding up our release and we need this to be fixed asap.
cc: @v-atulyadav

[v-prasadboke]

Hello @ashwinvenkatesha, As discussed we will be working on this and try to resolve it from our.

Will be checking with MS team if needed

[ashwinvenkatesha]

Here is the fix which helped unblock me
d40340c

[v-visodadasi]

Hi @ashwinvenkatesha , I wanted to check in and see if the issue has been resolved from your end. Please let me know at your earliest convenience.