Skip to content
This repository has been archived by the owner on Mar 16, 2023. It is now read-only.

Unused parameter in JoinSplitProof65793.encodeABI #519

Open
jlcs-es opened this issue May 14, 2020 · 0 comments
Open

Unused parameter in JoinSplitProof65793.encodeABI #519

jlcs-es opened this issue May 14, 2020 · 0 comments

Comments

@jlcs-es
Copy link

jlcs-es commented May 14, 2020

Expected Behaviour

JoinSplitProof65793.encodeABI should not ask for a validator address

Current Behaviour

https://github.com/AztecProtocol/AZTEC/blob/2248b4b08ffbd8a1d98cfc04a4fbcb9aa23977d9/packages/aztec.js/src/proof/proofs/BALANCED/epoch0/joinSplit/index.js#L159-L167

The validator variable is only used to check if it is an Ethereum Address, it isn't used anymore in the method.

Context

The method is used in the Ganache demo, passing the same address as in JoinSplitProof65793.constructSignatures

https://github.com/AztecProtocol/aztec-ganache-starter-kit/blob/754ac4bce4e238310f357b964cc925267b186082/test/demo.js#L73-L77

But it goes against the documentation of both methods (this is what raised my concerns):

verifyingContract  | string | Ethereum address of the ZkAsset contract, from which confidentialTransfer() is called

vs

validator | string | Ethereum address of the join-split validator contract

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant