From fbd5ddfd4df6c5ce700a831419acad167788ce93 Mon Sep 17 00:00:00 2001 From: Facundo Date: Fri, 10 Jan 2025 13:31:32 +0000 Subject: [PATCH] Apply suggestions from code review --- barretenberg/cpp/pil/vm2/execution.pil | 2 +- barretenberg/cpp/src/barretenberg/vm2/simulation/execution.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/barretenberg/cpp/pil/vm2/execution.pil b/barretenberg/cpp/pil/vm2/execution.pil index 9efa623a70b9..5718674edb50 100644 --- a/barretenberg/cpp/pil/vm2/execution.pil +++ b/barretenberg/cpp/pil/vm2/execution.pil @@ -35,7 +35,7 @@ last * (1 - last) = 0; // sel ^ (¬sel' ^ ¬last) = 0 iff // sel * (1 - sel') * (1 - last) = 0 #[TRACE_CONTINUITY_1] -sel * ((1 - sel') * (1 - last)) = 0; +sel * (1 - sel') * (1 - last) = 0; // If the current row is not an execution row, then there are no more execution rows after that. // (not enforced for the first row) #[TRACE_CONTINUITY_2] diff --git a/barretenberg/cpp/src/barretenberg/vm2/simulation/execution.cpp b/barretenberg/cpp/src/barretenberg/vm2/simulation/execution.cpp index 9fad6859f843..5e9ee473f83d 100644 --- a/barretenberg/cpp/src/barretenberg/vm2/simulation/execution.cpp +++ b/barretenberg/cpp/src/barretenberg/vm2/simulation/execution.cpp @@ -19,7 +19,7 @@ void Execution::add(ContextInterface& context, MemoryAddress a_addr, MemoryAddre alu.add(context, a_addr, b_addr, dst_addr); } -// TODO: My dispatch system makes me ahve a uint8_t tag. Rethink. +// TODO: My dispatch system makes me have a uint8_t tag. Rethink. void Execution::set(ContextInterface& context, MemoryAddress dst_addr, uint8_t tag, MemoryValue value) { context.get_memory().set(dst_addr, std::move(value), static_cast(tag));