Merge pull request magento-hackathon#29 from SlayerBirden/array_combine_fix

fix for array_combine and php 5.3

Author: Flyingmana

src/MagentoHackathon/Composer/Magento/ModuleManager.php

@@ -137,16 +137,17 @@ public function doRemoves(array $packagesToRemove)
     public function getRemoves(array $currentComposerInstalledPackages, array $magentoInstalledPackages)
     {
         //make the package names as the array keys
-        $currentComposerInstalledPackages = array_combine(
-            array_map(
-                function (PackageInterface $package) {
-                    return $package->getPrettyName();
-                },
+        if (count($currentComposerInstalledPackages)) {
+            $currentComposerInstalledPackages = array_combine(
+                array_map(
+                    function (PackageInterface $package) {
+                        return $package->getPrettyName();
+                    },
+                    $currentComposerInstalledPackages
+                ),
                 $currentComposerInstalledPackages
-            ),
-            $currentComposerInstalledPackages
-        );
-
+            );
+        }
         return array_filter(
             $magentoInstalledPackages,
             function (InstalledPackage $package) use ($currentComposerInstalledPackages) {

tests/MagentoHackathon/Composer/Magento/ModuleManagerTest.php

@@ -117,4 +117,19 @@ public function testMultipleInstallsAndUnInstalls()
         $this->assertSame($installedMagentoPackages, $result[0]);
         $this->assertSame($composerInstalledPackages, $result[1]);
     }
+    
+    public function testEmptyComposerInstalledPackages()
+    {
+        $installedMagentoPackages = array(
+            new InstalledPackage("vendor/package1", "1.0.0", array()),
+            new InstalledPackage("vendor/package2", "1.0.0", array()),
+        );
+
+        $this->installedPackageRepository->add($installedMagentoPackages[0]);
+        $this->installedPackageRepository->add($installedMagentoPackages[1]);
+
+        $result = $this->moduleManager->updateInstalledPackages(array());
+        $this->assertSame($installedMagentoPackages, $result[0]);
+        $this->assertEmpty($result[1]);
+    }
 }