Skip to content
This repository was archived by the owner on Feb 21, 2023. It is now read-only.
This repository was archived by the owner on Feb 21, 2023. It is now read-only.

Warning | validateDOMNesting For Helper Ref #51

Open
@GoPro16

Description

@GoPro16

Currently if a user wants to override the tag prop of react-block-ui they can but it doesn't account for warnings that may come up if per say we were to have a tag of <tbody>

Example Code:

<BlockUI tag="tbody">
   <td>hello</td>
</BlockUI>

rendered HTML

<tbody>
   <td>hello</td>
   <span />
</tbody>
Warning: validateDOMNesting(...): <span> cannot appear as a child of <tbody>.

Code Link

I would suggest the we move the span ref helper out of the component and return BlockUI as a fragment of both. Then we can just have the span grab the same element from helper.previousSibling to allow any tag to be overridden for the BlockUI tag prop.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions