You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Currently if a user wants to override the tag prop of react-block-ui they can but it doesn't account for warnings that may come up if per say we were to have a tag of <tbody>
Example Code:
<BlockUItag="tbody"><td>hello</td></BlockUI>
rendered HTML
<tbody><td>hello</td><span/></tbody>
Warning: validateDOMNesting(...): <span> cannot appear as a child of <tbody>.
I would suggest the we move the span ref helper out of the component and return BlockUI as a fragment of both. Then we can just have the span grab the same element from helper.previousSibling to allow any tag to be overridden for the BlockUI tag prop.
The text was updated successfully, but these errors were encountered:
Currently if a user wants to override the
tag
prop ofreact-block-ui
they can but it doesn't account for warnings that may come up if per say we were to have a tag of<tbody>
Example Code:
rendered HTML
Code Link
I would suggest the we move the
span
ref helper out of the component and return BlockUI as a fragment of both. Then we can just have thespan
grab the same element fromhelper.previousSibling
to allow any tag to be overridden for theBlockUI
tag prop.The text was updated successfully, but these errors were encountered: