Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove style variation badges from the theme card #93931

Closed
2 tasks
richtabor opened this issue Aug 26, 2024 · 2 comments · Fixed by #97655
Closed
2 tasks

Remove style variation badges from the theme card #93931

richtabor opened this issue Aug 26, 2024 · 2 comments · Fixed by #97655
Assignees
@paulopmt1
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes.

Comments

@richtabor
Copy link

richtabor commented Aug 26, 2024 •
edited
Loading

As an alternate to #93799 and a resolution to many noticeable quirks with style variations displaying on the showcase grid views, I propose we simply remove these style variation badges.

Requirements

  • Remove the style variation badges from theme cards.
  • Position the theme-tier-badge to the right of the title, where the style variation badges were.

Visual

Image
@richtabor richtabor mentioned this issue Aug 26, 2024
Open
@richtabor richtabor added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. labels Aug 26, 2024
@vcanales vcanales mentioned this issue Sep 12, 2024
Closed
7 tasks
@fditrapani fditrapani mentioned this issue Dec 9, 2024
Open
1 task
@fditrapani
Copy link
Contributor

fditrapani commented Dec 9, 2024 •
edited
Loading

Related to this, I shared an update to the theme cards here: #95471 (comment)

@fditrapani fditrapani mentioned this issue Dec 10, 2024
Open
@paulopmt1 paulopmt1 self-assigned this Dec 19, 2024
@paulopmt1 paulopmt1 mentioned this issue Dec 19, 2024
Merged
8 tasks
@paulopmt1 paulopmt1 linked a pull request Dec 19, 2024 that will close this issue
Update theme badge labels #97655
Merged
8 tasks
@arthur791004
Copy link
Contributor

Looks like we should remove the style variation badges on the Theme Showcase as well, right?

@arthur791004 arthur791004 mentioned this issue Dec 26, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulopmt1 paulopmt1

Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update theme badge labels Automattic/wp-calypso
5 participants
@paulopmt1 @vcanales @richtabor @fditrapani @arthur791004