Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Flow Improvements: Replace Redux state with hooks for getting site-aware pricing and introductory offer on the Upgrade plan step #92221

Open
merkushin opened this issue Jun 28, 2024 · 3 comments

Comments

@merkushin
Copy link
Member

Details

As per this discussion, we should avoid using Redux state whenever we have an option to use a hook.

For the Upgrade step (client/blocks/importer/wordpress/upgrade-plan/upgrade-plan-details.tsx), we have the following hooks:

  • usePricingMetaForGridPlans to get information on the pricing;
  • useIntroOffers to get information about the introductory offer.

It might make sense to look at other options that suit better.

Checklist

No response

Related

No response

@chriskmnds
Copy link
Contributor

Thanks. I left a comment/response here: #92088 (comment)

Please reply on my two inquiries there so we can align. I'd be greatful. 🙇

@daledupreez
Copy link
Contributor

@merkushin, Serenity can also step in to tackle this aspect of the refactor so you can focus on exposing the introductory offers.

@chriskmnds
Copy link
Contributor

Thank you. I'm stripping out other selectors (like getPlanRawPrice #92235), so eventually our efforts will converge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants