Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site style for links overrides the block style for links #78013

Closed
philnick206 opened this issue Jun 9, 2023 · 3 comments
Closed

Site style for links overrides the block style for links #78013

philnick206 opened this issue Jun 9, 2023 · 3 comments
Labels
[Closed] Duplicate Duplicate of an existing issue. [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@philnick206
Copy link

Quick summary

If I set a custom Font Family for a Page Link block, that font is shown correctly in the editor and site:

gMfPVDWbcMoCjZnyLkCIsIhL5WbyNq13UhSZOf6n.jpg

However, if I then set a different Font Family than “Default” for my site’s Links under global styles, that Font Family will override the setting set on the individual Page Link blocks in the Navigation block:

SHslGSVLfgS6rghruH47qEXBnt6mvEAtczuiLGAB.jpg

The same behavior can be observed for size and color settings.

Steps to reproduce

  1. Set a font family for Page Links in the Navigation block to a font other than the default
  2. Change the font family to a different font again for Links in the site's styles editor

What you expected to happen

All links on the site should show the font family specified in the site's styles editor EXCEPT where the font family was set to something different on an individual block.

What actually happened

All links on the site changed to the font family specified in the site's styles editor, no matter what their local block settings for links were set to.

Impact

Some (< 50%)

Available workarounds?

Yes, difficult to implement

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

Tested on theme Upsidedown

@philnick206 philnick206 added [Type] Bug User Report This issue was created following a WordPress customer report labels Jun 9, 2023
@github-actions github-actions bot added [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. labels Jun 9, 2023
@john-legg
Copy link
Contributor

📌 REPRODUCTION RESULTS

Tested on Simple – Replicated
Tested on Atomic – Replicated
Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

I was able to reproduce the issue on Chrome, Firefox, and Safari with different plans and themes on Simple and Atomic (WPCOM and self-hosted).

Site.Style.Override.mov

It also appears that changing the local style after setting the sitewide style still doesn't allow the block style to be changed.

Site.Style.Override.2.mov

📌 ACTIONS

Assigned to T-Rex column (@Automattic/t-rex). Please feel free to reassign if needed!

@cuemarie
Copy link

I think this is actually a duplicate of:

@john-legg Do you agree?

@john-legg
Copy link
Contributor

Ah, great catch, Marie! I definitely agree, so I'll close this as a duplicate of #74234.

@john-legg john-legg closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
@john-legg john-legg added the [Closed] Duplicate Duplicate of an existing issue. label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Duplicate Duplicate of an existing issue. [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

3 participants