Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure editor mobile zoom works #42148

Closed
simison opened this issue May 13, 2020 · 10 comments
Closed

Ensure editor mobile zoom works #42148

simison opened this issue May 13, 2020 · 10 comments
Assignees
Labels
[Closed] Fixed Issues explicitly fixed with PRs. Do not use for no longer reproducible issues. [Goal] Gutenberg Working towards full integration with Gutenberg Mobile Web [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug

Comments

@simison
Copy link
Member

simison commented May 13, 2020

Editor's zoom might be broken on iOS devices:

On my Iphone 11 Pro, running chrome in incognito mode.

@simison simison added [Type] Bug [Goal] Gutenberg Working towards full integration with Gutenberg Mobile Web [Pri] High Address as soon as possible after BLOCKER issues labels May 13, 2020
@sirreal
Copy link
Member

sirreal commented May 13, 2020

I've been testing via iOS simulators and Safari, and I've been unable to reproduce this error.

I don't have the hardware necessary to test Chrome on a recent iOS device.

@yansern
Copy link
Contributor

yansern commented May 14, 2020

I think the quick fix is to find a way to set this to "Mobile" when a mobile browser is detected on editor launch.

image

image

@sirreal
Copy link
Member

sirreal commented May 14, 2020

There may be some insights here: WordPress/gutenberg#21102
That might fix any issues like this.

@tjcafferkey
Copy link
Contributor

After some investigation I found that these styles getting applied in the Block Editor from this file (26dde-pb) are causing the issue. Commenting them out appears to fix the issue but we don't want to do that.

I have logged an issue Automattic/block-experiments#152 to understand more about why they exist as I'm sure there's a reason they belong there.

@roo2
Copy link
Contributor

roo2 commented Dec 16, 2020

@tjcafferkey @simison @yansern I've raised Automattic/block-experiments#161 which is a potential solution to allow the editor to work intuitively for mobile and still support the current preview mode

@cathymcbride
Copy link
Contributor

@worldomonation this should be fixed from a recent check in. Can you verify that?

@worldomonation
Copy link
Contributor

@worldomonation this should be fixed from a recent check in. Can you verify that?

I took a look. My understanding of the issue is that when entering the editor using an iOS browser, the editor is not sized for the mobile phone screen.

If my understanding is correct, then I can confirm the editor experience on iOS Safari is as I would expect. For more information, please see attached screen recording of my interactions:
https://d.pr/v/O72Sce

@worldomonation
Copy link
Contributor

I also checked the Column block type on mobile and tested the responsive breakpoints:
スクリーンショット 2021-02-04 15 33 38
Edit Post ‹ Edwin's Test Site 1 — WordPress

@worldomonation
Copy link
Contributor

I've also checked on desktop Firefox that following works:

  1. insert Layout Grid block.
  2. fill in some content in each of the columns.
  3. from block options, select Mobile for Responsive Breakpoint.
  4. enter preview.
  5. change preview mode to Mobile.

The resulting preview is in line with the selected breakpoint.

@johngodley
Copy link
Member

This should now be fixed as part of Automattic/block-experiments#161 - the preview dropdown is hidden on mobile, and the grid will display the mobile breakpoint by default.

I'll close this as resolved. If there are remaining problems please create an issue for them here. Thanks!

@cathymcbride cathymcbride added the [Closed] Fixed Issues explicitly fixed with PRs. Do not use for no longer reproducible issues. label Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Fixed Issues explicitly fixed with PRs. Do not use for no longer reproducible issues. [Goal] Gutenberg Working towards full integration with Gutenberg Mobile Web [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug
Projects
None yet
Development

No branches or pull requests

8 participants