Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans: Comparison grid not sticky to the top #101152

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

katinthehatsite
Copy link
Contributor

@katinthehatsite katinthehatsite commented Mar 11, 2025

Closes #101110

Proposed Changes

This PR reduces the offset on the top for the sticky plan type selector on mobile to ensure that there is no gap on the top:

Image 1 Image 2

Testing Instructions

  • Pull the changes from this branch or navigate to Calypso Live Link
  • Navigate to /setup/onboarding/plans?source=sites-dashboard&ref=new-site-popover
  • Switch to mobile you in your browser
  • Select a paid domain
  • Once you are on the plans page, scroll to the bottom and select Compare plans
  • Observe that the plan comparison grid is sticky to the top when you scroll

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@katinthehatsite katinthehatsite self-assigned this Mar 11, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@katinthehatsite katinthehatsite requested a review from a team March 11, 2025 15:10
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 11, 2025
@matticbot
Copy link
Contributor

matticbot commented Mar 11, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/padding-on-plan-grid on your sandbox.

Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good and fixes the issue:

Markup on 2025-03-11 at 17:21:12

@katinthehatsite katinthehatsite merged commit 470f938 into trunk Mar 12, 2025
13 checks passed
@katinthehatsite katinthehatsite deleted the fix/padding-on-plan-grid branch March 12, 2025 07:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plans: Comparison grid not sticky to the top
3 participants