Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty link in a block cannot be removed until it's fixed with a proper destination #100058

Open
arunsathiya opened this issue Feb 20, 2025 · 6 comments
Labels
[Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@arunsathiya
Copy link
Contributor

arunsathiya commented Feb 20, 2025

Context and steps to reproduce

When there's a empty link on a block, it is currently not possible to remove it just by clicking on the link icon.

Image

The link seems to be reconfigured with a proper destination and then removed.

Image

I am not sure what causes a empty link to exist in the first place, but here is a test block you can reproduce the issue with:

<!-- wp:paragraph -->
<p><a>This is a test.</a></p>
<!-- /wp:paragraph -->

Suggestion - When there is a empty link, clicking on the link icon should remove the link without having to configure a proper destination first.

Site owner impact

Fewer than 20% of the total website/platform users

Severity

Minor

What other impact(s) does this issue have?

No response

If a workaround is available, please outline it here.

No response

Platform

Simple, Self-hosted, Atomic

@arunsathiya arunsathiya added [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Full Site Editor The site editor. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Feb 20, 2025
@arunsathiya
Copy link
Contributor Author

arunsathiya commented Feb 20, 2025

I can reproduce on a simple site and a dotorg site (Pressable site), which ship with Gutenberg out of the box and I can reproduce the issue with Twenty Twenty-Five.

Image

However, on an Atomic site that has Gutenberg 20.0.0, which is shipped by the host too, there is a proper "Unlink" functionality for the empty link.

Image

So, I suppose Gutenberg 20.0.0 and higher fixes this issue, but I am yet to test if that's the case. Could someone test with Gutenberg 20.0.0 on a Dotorg site?

@github-actions github-actions bot added the [Pri] Low Address when resources are available. label Feb 20, 2025
@arunsathiya arunsathiya changed the title Phantom link in a block cannot be removed until it's fixed with a proper destination Empty link in a block cannot be removed until it's fixed with a proper destination Feb 20, 2025
@janmckell
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO
Tested on Atomic Dotcom site with TieBreak theme - unlink icon shows - Gutenberg not activated on the site

Image

Tested on Simple Dotcom site with TieBreak theme - unlink icon does not show

Image

Tested on Studio local site with Twenty Twenty Four theme - unlink icon does not show - tested with both Gutenberg 19.8 and 20.3.0

📌 ACTIONS

  • Triaged

→ Asked about assigning ownership here: p1740095264495959-slack-C03NLNTPZ2T

@janmckell janmckell removed the Needs triage Ticket needs to be triaged label Feb 20, 2025
@janmckell janmckell moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Feb 20, 2025
@Robertght
Copy link

@arunsathiya @janmckell I'm currently checking this and I was not able to replicate it, however, it would be great to share the steps or a short recording of the issue.

@janmckell I can see you managed to replicate this so it looks like a core GB issue we need to report. I couldn't find something similar on the main repository so probably a new one should be added.

@arunsathiya
Copy link
Contributor Author

@Robertght Thanks for the ping. I can certainly share a video but it might be a day or two before I can get back here. I will be in touch!

@janmckell
Copy link

"I can see you managed to replicate this so it looks like a core GB issue we need to report. I couldn't find something similar on the main repository so probably a new one should be added."

Hey @Robertght Thanks for the ping.
Yes! "It should be reported in the core Gutenberg repo, without referencing Dotcom in reproduction steps, and then our [TOB] board can link out to that issue."

@janmckell
Copy link

A Gutenberg issue has been created here:
WordPress/gutenberg#69481

@Robertght @arunsathiya

Please take a look and let me know if there are any other details that need to be added to it.

@Robertght Robertght moved this from In Triage to Triaged in Automattic Prioritization: The One Board ™ Mar 7, 2025
@Robertght Robertght added the [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. label Mar 7, 2025
@Robertght Robertght moved this from Triaged to Needs Core/3rd Party Fix in Automattic Prioritization: The One Board ™ Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Type] Bug When a feature is broken and / or not performing as intended
Projects
Status: Needs Core/3rd Party Fix
Development

No branches or pull requests

3 participants