Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove payout rename notice code #9704

Closed
shendy-a8c opened this issue Nov 12, 2024 · 3 comments · Fixed by #10039
Closed

Remove payout rename notice code #9704

shendy-a8c opened this issue Nov 12, 2024 · 3 comments · Fixed by #10039
Assignees
@shendy-a8c
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: payouts priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: task The issue is an internally driven task (e.g. from another A8c team).
Milestone
WooPayments 8.8.0

Comments

@shendy-a8c
Copy link
Contributor

From paJDYF-fwb-p2 where we renamed 'deposit' to 'payout', we introduced a spotlight notice to bring awareness to users that deposit has been renamed to payout in WooPayments 8.5.0.

This code needs to be removed when this rename is no longer 'new', possibly after couple releases ahead, 8.7.0 or later.
@haszari haszari added the category: projects For any issues which are part of any project, including bugs, enhancements, etc. label Nov 13, 2024
@haszari haszari mentioned this issue Nov 14, 2024
Open
@haszari
Copy link
Contributor

haszari commented Nov 14, 2024

@rogermattic @souravdebnath1986 how long should we keep the Deposits is now Payouts spotlight notice in play?

@shendy-a8c above suggested 1-2 releases, let's align on a specific target release to remove it.

Options:

  1. WooPayments 8.6 (next release) ships Dec ~4 2024
  2. WooPayments 8.7 (+2 releases) ships Dec ~25 2024
  3. Some release further in the future ships 2025

I'd suggest 8.6 – this gives merchants that update regularly ~3 weeks to see the notice.

@haszari haszari added priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: task The issue is an internally driven task (e.g. from another A8c team). labels Nov 14, 2024
@souravdebnath1986
Copy link

We should keep this spotlight notice for 2 months until mid-Jan 2025. This is based on the assumption that merchants check on payouts from daily to weekly and at least monthly and the suggested time period would cover majority of active merchants.

@nagpai nagpai added this to the WooPayments 8.8.0 milestone Nov 22, 2024
@nagpai
Copy link
Contributor

nagpai commented Nov 22, 2024

We should keep this spotlight notice for 2 months until mid-Jan 2025.

WooPayments 8.8.0 is scheduled for January 12, 2025. I have added that as milestone.

@shendy-a8c shendy-a8c self-assigned this Dec 24, 2024
@shendy-a8c shendy-a8c mentioned this issue Dec 24, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shendy-a8c shendy-a8c

Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: payouts priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Milestone
WooPayments 8.8.0
Development

Successfully merging a pull request may close this issue.

Remove payouts rename notice overlay. Automattic/woocommerce-payments
4 participants
@nagpai @haszari @shendy-a8c @souravdebnath1986