Skip to content

Commit 1fc3cfe

Browse files
Merge pull request #73 from Automattic/develop
Simplenote Mark 4.4
2 parents b43ffb6 + 140d256 commit 1fc3cfe

File tree

8 files changed

+38
-25
lines changed

8 files changed

+38
-25
lines changed

External/DTPinLock/DTPinLockController.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -506,8 +506,8 @@ - (void)dismissKeyboard
506506

507507
- (void)cancel:(id)sender
508508
{
509-
[self.view endEditing:YES];
510-
509+
[self dismissKeyboard];
510+
511511
// if there is a delegate method, then we let it deal with it
512512
if (pinLockDelegate && [pinLockDelegate respondsToSelector:@selector(pinLockControllerDidCancel)])
513513
{

Podfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ abstract_target 'Automattic' do
2727
# Automattic
2828
#
2929
pod 'Automattic-Tracks-iOS', :git => 'https://github.com/Automattic/Automattic-Tracks-iOS.git', :tag => '0.1.0'
30-
pod 'Simperium', '0.8.16'
30+
pod 'Simperium', '0.8.17'
3131
pod 'WordPress-AppbotX', :git => 'https://github.com/wordpress-mobile/appbotx.git', :commit => '479d05f7d6b963c9b44040e6ea9f190e8bd9a47a'
3232
pod 'WordPress-Ratings-iOS', '0.0.2'
3333
end

Podfile.lock

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,17 @@ PODS:
2323
- hoedown/standard (= 3.0.3)
2424
- hoedown/standard (3.0.3)
2525
- Reachability (3.2)
26-
- Simperium (0.8.16):
27-
- Simperium/DiffMatchPach (= 0.8.16)
28-
- Simperium/JRSwizzle (= 0.8.16)
29-
- Simperium/SocketRocket (= 0.8.16)
30-
- Simperium/SPReachability (= 0.8.16)
31-
- Simperium/SSKeychain (= 0.8.16)
32-
- Simperium/DiffMatchPach (0.8.16)
33-
- Simperium/JRSwizzle (0.8.16)
34-
- Simperium/SocketRocket (0.8.16)
35-
- Simperium/SPReachability (0.8.16)
36-
- Simperium/SSKeychain (0.8.16)
26+
- Simperium (0.8.17):
27+
- Simperium/DiffMatchPach (= 0.8.17)
28+
- Simperium/JRSwizzle (= 0.8.17)
29+
- Simperium/SocketTrust (= 0.8.17)
30+
- Simperium/SPReachability (= 0.8.17)
31+
- Simperium/SSKeychain (= 0.8.17)
32+
- Simperium/DiffMatchPach (0.8.17)
33+
- Simperium/JRSwizzle (0.8.17)
34+
- Simperium/SocketTrust (0.8.17)
35+
- Simperium/SPReachability (0.8.17)
36+
- Simperium/SSKeychain (0.8.17)
3737
- SSKeychain (1.2.2)
3838
- SVProgressHUD (1.1.2)
3939
- UIDeviceIdentifier (0.5.0)
@@ -48,7 +48,7 @@ DEPENDENCIES:
4848
- GoogleAnalytics (= 3.14.0)
4949
- HockeySDK (~> 3.8.0)
5050
- hoedown (~> 3.0.3)
51-
- Simperium (= 0.8.16)
51+
- Simperium (= 0.8.17)
5252
- SSKeychain (= 1.2.2)
5353
- SVProgressHUD (= 1.1.2)
5454
- WordPress-AppbotX (from `https://github.com/wordpress-mobile/appbotx.git`, commit `479d05f7d6b963c9b44040e6ea9f190e8bd9a47a`)
@@ -80,13 +80,13 @@ SPEC CHECKSUMS:
8080
HockeySDK: ab68303eec6680f6b539de65d747742dd276e934
8181
hoedown: c1327bbbc96d269595ed86bf97f1d09867ec7529
8282
Reachability: 33e18b67625424e47b6cde6d202dce689ad7af96
83-
Simperium: 07a07d958dfdbd65febde942214d10525d49aa0c
83+
Simperium: 0111b16b6d72bc598a99e244ef87025ae433b27e
8484
SSKeychain: 88767e903ee8d274ed380e364d96b7a101235286
8585
SVProgressHUD: 3afb875b9eb23acd1bed9b82495695c68621a8b2
8686
UIDeviceIdentifier: a959a6d4f51036b4180dd31fb26483a820f1cc46
8787
WordPress-AppbotX: b5abc0ba45e3da5827f84e9f346c963180f1b545
8888
WordPress-Ratings-iOS: b04108f7a45867844ba47a240bb6295ca747eebf
8989

90-
PODFILE CHECKSUM: 85792041d567f2099884924acdc40b1a646f6b91
90+
PODFILE CHECKSUM: 2d182e50997cbe1e2b8976426df9b496171dd193
9191

9292
COCOAPODS: 1.0.1

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@
22
A Simplenote client for iOS. Learn more about Simplenote at [Simplenote.com](https://simplenote.com).
33

44
## Development Requirements
5-
* A Simperium account. [Sign up here](https://simperium.com/signup/)
6-
* A Simperium Application ID and key. [Create a new app here](https://simperium.com/app/new/)
5+
* A Simperium account ([sign up here](https://simperium.com/signup/)).
6+
* A Simperium Application ID and key ([create a new app here](https://simperium.com/app/new/)).
7+
* [CocoaPods](https://cocoapods.org/).
8+
* [Xcode](https://developer.apple.com/xcode/).
79

810
## Running
911

Simplenote/Classes/SPAddCollaboratorsViewController.m

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ - (void)viewDidLoad
3232

3333
// set navigation bar
3434
self.navigationItem.title = NSLocalizedString(@"Collaborators", @"Noun - collaborators are other Simplenote users who you chose to share a note with");
35-
35+
self.navigationItem.rightBarButtonItem = [[UIBarButtonItem alloc] initWithTitle:NSLocalizedString(@"Done", nil) style:UIBarButtonItemStyleDone target:self action:@selector(onDone)];
36+
3637
entryTextField.placeholder = NSLocalizedString(@"Add a new collaborator...", @"Noun - collaborators are other Simplenote users who you chose to share a note with");
3738

3839
if (!self.dataSource)
@@ -261,6 +262,14 @@ - (void)updateAutoCompleteMatchesForString:(NSString *)string {
261262
[self updatedAutoCompleteMatches];
262263
}
263264

265+
#pragma mark - Buttons
266+
267+
- (void)onDone
268+
{
269+
[self processTextInField];
270+
[self.navigationController dismissViewControllerAnimated:YES completion:nil];
271+
}
272+
264273
#pragma mark ABPeoplePickerNavigationControllerDelegate methods
265274

266275
- (void)peoplePickerNavigationControllerDidCancel: (ABPeoplePickerNavigationController *)peoplePicker

Simplenote/Classes/SPNoteEditorViewController.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1660,7 +1660,9 @@ - (void)shareNoteContentAction:(id)sender {
16601660

16611661
[SPTracker trackEditorNoteContentShared];
16621662

1663-
UIActivityViewController *acv = [[UIActivityViewController alloc] initWithActivityItems:@[_currentNote.content]
1663+
UISimpleTextPrintFormatter *print = [[UISimpleTextPrintFormatter alloc] initWithText:_currentNote.content];
1664+
1665+
UIActivityViewController *acv = [[UIActivityViewController alloc] initWithActivityItems:@[_currentNote.content, print]
16641666
applicationActivities:nil];
16651667

16661668
if ([UIDevice isPad]) {

Simplenote/Simplenote-Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<key>CFBundlePackageType</key>
1818
<string>APPL</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>4.3.4</string>
20+
<string>4.4</string>
2121
<key>CFBundleSignature</key>
2222
<string>????</string>
2323
<key>CFBundleURLTypes</key>
@@ -32,7 +32,7 @@
3232
</dict>
3333
</array>
3434
<key>CFBundleVersion</key>
35-
<string>4340</string>
35+
<string>4400</string>
3636
<key>Fabric</key>
3737
<dict>
3838
<key>APIKey</key>

SimplenoteShare/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@
2121
<key>CFBundlePackageType</key>
2222
<string>XPC!</string>
2323
<key>CFBundleShortVersionString</key>
24-
<string>4.3.4</string>
24+
<string>4.4</string>
2525
<key>CFBundleSignature</key>
2626
<string>????</string>
2727
<key>CFBundleVersion</key>
28-
<string>4340</string>
28+
<string>4400</string>
2929
<key>NSExtension</key>
3030
<dict>
3131
<key>NSExtensionAttributes</key>

0 commit comments

Comments
 (0)