Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache issues with lesson ordering #7146

Open
renatho opened this issue Sep 1, 2023 · 5 comments · May be fixed by #7654
Open

Cache issues with lesson ordering #7146

renatho opened this issue Sep 1, 2023 · 5 comments · May be fixed by #7654
Assignees
@merkushin
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Type] Bug

Comments

@renatho
Copy link
Contributor

renatho commented Sep 1, 2023

Steps to Reproduce

  1. Create an atomic site (I tested on Pressable).
  2. Create a course with modules and lessons.
  3. Save it.
  4. Change the lessons order.
  5. Save it, and refresh the editor.

What I Expected

To see the lessons in the saved order.

What Happened Instead

The previous order is displayed.

The same issue happens if we sort the lessons through Sensei LMS > Lessons > Order Lessons, and check the order in the frontend (the order in the frontend will be cached).

PHP / WordPress / Sensei LMS version

PHP 8.1 / WordPress 6.3.1 / Sensei LMS 4.16.1

Browser / OS version

Chrome

Screenshot / Video

Screen.Recording.2023-09-01.at.11.50.12.mov

Context / Source

A while ago, I worked on #4236, fixing a related thing. The cause here is the same cache, but in different parts of the code. Since it's been a while, I don't remember exactly the causes in the core, but maybe going deeper into the issue again, we could find a better solution. If not, a short-term solution could be always avoiding the cache in that situation, but I'm not sure about performance complications.

More context:

  • p1693520624650459/1692982559.274589-slack-C02P7FHLVR9
  • 6700401-zd-a8c (I'm not totally sure if it's the issue for this user)
@github-actions
Copy link

github-actions bot commented Sep 1, 2023 •
edited
Loading

Support References

This comment is automatically generated. Please do not edit it.

  • 6700401-zen
  • 8437141-zen
  • 8589276-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 1, 2023
@donnapep
Copy link
Collaborator

Related #6632

@joashrajin
Copy link

This user reports that Lesson and Module ordering resets after saving

8437141-zd-a8c

@merkushin merkushin self-assigned this Aug 1, 2024
@merkushin merkushin linked a pull request Aug 1, 2024 that will close this issue
Avoid caching when getting course structure #7654
Draft
15 tasks
@merkushin merkushin linked a pull request Aug 1, 2024 that will close this issue
Draft
15 tasks
@igotdes
Copy link

igotdes commented Aug 6, 2024

User in #8437141-zen says they tried the fix above, but it didn't work for them:

[...] I applied the patch to the corresponding file in Sensei, but it still does not work.

@jinnypark
Copy link
Member

8589276-zen

I'm trying to change the order of lessons or modules and after I make any edit and press save the order returns to what it was before (the changes are not saved)
We've already upped our max_input_vars in case this was the issue but this doesn't resolve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merkushin merkushin

Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid caching when getting course structure Automattic/sensei
6 participants
@merkushin @renatho @donnapep @jinnypark @joashrajin @igotdes