Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Edit Lesson" toolbar option not working with tour #7625

Closed
donnapep opened this issue Jul 4, 2024 · 3 comments · Fixed by #7652
Closed

"Edit Lesson" toolbar option not working with tour #7625

donnapep opened this issue Jul 4, 2024 · 3 comments · Fixed by #7652
Assignees
Labels
[Pri] Normal Can wait for the next release [Status] Needs Triage Issue needs to be triaged [Type] Bug
Milestone

Comments

@donnapep
Copy link
Collaborator

donnapep commented Jul 4, 2024

Steps to Reproduce

See #7625 (comment). We should try to reproduce this user-reported issue.

Please note that I didn't try these steps, but it should theoretically highlight the bug:

- Add the following code to functions.php of the active theme:

function example_allowed_block_types( $allowed_block_types, $block_editor_context ) {

	$allowed_block_types = array(
		'core/heading',
		'core/image',
		'core/paragraph',
	);

	return $allowed_block_types;
}
add_filter( 'allowed_block_types_all', 'example_allowed_block_types', 10, 2 );
  • Create a brand new Sensei site.
  • Create a new course.
  • The tour should be visible, but does not function properly as the Sensei blocks are unavailable in the editor.
  • Add a quiz to a lesson.
  • The tour should be visible, but does not function properly as the Sensei blocks are unavailable in the editor.

Context / Source

From https://x.com/carolinapoena/status/1806837840031928323?s=46&t=tLqu-4WGyvBs1cDTKpVGSg:

Next, the steps in the interactive tour does not match the options that are available for the custom blocks on the screen, so I can't use the tutorial to create and edit my first course anyway.

@donnapep donnapep added [Type] Bug [Pri] Normal Can wait for the next release [Status] Needs Triage Issue needs to be triaged labels Jul 4, 2024
@donnapep donnapep added this to the 4.24.2 milestone Jul 4, 2024
@donnapep
Copy link
Collaborator Author

donnapep commented Jul 16, 2024

Tried the filter given in the PR description but wasn't able to reproduce. The tour was not displayed at all in this case.

@carolinan Any insight you could provide into this Sensei issue as reported by you on Twitter would be appreciated. 🙏🏻

@carolinan
Copy link

carolinan commented Jul 17, 2024

The main problem I had was when the tutorial / wizard suggested that I should edit the lesson, the button in the block toolbar did nothing.
It said it would take me to the "lesson editor", but nothing happened.
So I was never able to edit the lesson.

@donnapep donnapep changed the title Don't show course outline or quiz tours if blocks aren't available in editor "Edit Lesson" toolbar option not working with tour Jul 18, 2024
@donnapep
Copy link
Collaborator Author

For whoever picks this one up, I wasn't able to reproduce but we should spend some time trying to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Can wait for the next release [Status] Needs Triage Issue needs to be triaged [Type] Bug
Projects
None yet
3 participants