Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerous console errors and warnings in the editor #7624

Open
donnapep opened this issue Jul 3, 2024 · 5 comments
Open

Numerous console errors and warnings in the editor #7624

donnapep opened this issue Jul 3, 2024 · 5 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged [Type] Bug

Comments

@donnapep
Copy link
Collaborator

donnapep commented Jul 3, 2024

Steps to Reproduce

  1. Install the WordPress Beta Tester plugin.
  2. Switch to the bleeding edge nightly.
  3. Open a course in the editor.
  4. There are errors / warnings in the console.
  5. Open a lesson in the editor.
  6. There are errors / warnings in the console.

What I Expected

No WordPress deprecation or block validation messages.

What Happened Instead

Several WordPress deprecation / block validation messages.

Screenshot / Video

Course

Screenshot 2024-07-03 at 3 00 33 PM

Lesson

Screenshot 2024-07-03 at 3 01 52 PM

Question

Screenshot 2024-07-03 at 3 04 15 PM

Context / Source

The tweet mentioned deprecations for WordPress 5.9, but I didn't come across any of those. We should click through other pages to see if we can find them:
https://x.com/carolinapoena/status/1806837840031928323?s=46&t=tLqu-4WGyvBs1cDTKpVGSg

@donnapep donnapep added [Type] Bug [Status] Triaged Issue has been triaged labels Jul 3, 2024
@donnapep donnapep added this to the 4.24.2 milestone Jul 3, 2024
@donnapep donnapep added the [Pri] Normal Can wait for the next release label Jul 3, 2024
@donnapep donnapep changed the title Numerous WordPress deprecation messages Numerous console errors and warnings in the editor Jul 3, 2024
@azollafox
Copy link

azollafox commented Jul 22, 2024

I believe this is the same issue we have a user report for, and I see on my demo site. If you head to wp-admin> Appearance> Editor> Template>sensei-course-theme and click on either option, all blocks there will display Your site doesn't include support for the "sensei-lms/ui" block. You can leave this block intact, convert its content to a Custom HTML block, or remove it entirely.

image

The errors I see in the browser Console on that page match what's reported here

The user and I are both on WordPress version: 6.6. I'm on the theme "Course" and the user is on Twenty Twenty-Four. The user report is in 8505410-zd

Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 8505410-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Jul 22, 2024
@renatho renatho assigned renatho and unassigned renatho Jul 22, 2024
@renatho
Copy link
Contributor

renatho commented Jul 31, 2024

I fixed most of the issues in the course/lesson/question editor with this PR: #7646. The items not fixed that I also documented in the PR are:

  • When navigating to the course editor, and navigating back (browser history), it gives the error Blocked attempt to show a 'beforeunload' confirmation panel for a frame that never had a user gesture since its load.. I could isolate it noticing that the warning is not displayed anymore when we remove the TextControl from the modal.
    • I didn't invest much time into that because it's external and not too critical.
  • Deprecated prop on Tour Kit wp-calypso#93167 - When using the tour, there is a warning about a deprecated prop (isElevated), which comes from Calypso.

We also have some warnings in the template editor and on the pages "Courses" and "My Courses".

That said, I'm not closing this issue yet.

@renatho
Copy link
Contributor

renatho commented Jul 31, 2024

I believe this is the same issue we have a user report for, and I see on my demo site. If you head to wp-admin> Appearance> Editor> Template>sensei-course-theme and click on either option, all blocks there will display Your site doesn't include support for the "sensei-lms/ui" block. You can leave this block intact, convert its content to a Custom HTML block, or remove it entirely.

The errors I see in the browser Console on that page match what's reported here

The user and I are both on WordPress version: 6.6. I'm on the theme "Course" and the user is on Twenty Twenty-Four. The user report is in 8505410-zd

Hi @azollafox!

I tried it on a fresh site, but I couldn't reproduce the issue. Maybe you have some other plugins installed that could be conflicting somehow?

Are you able to reproduct it in a site creating it from scratch? If so, could you list the steps for us?

From my side, what I tried:

  • Create a new site (WP 6.6 and Twenty Twenty-Four theme).
  • Install Sensei LMS plugin.
  • Navigate to WP admin > Appearance > Editor > Template > sensei-course-theme and click on either option.

@renatho renatho removed their assignment Aug 6, 2024
@renatho
Copy link
Contributor

renatho commented Aug 6, 2024

Moved back to "To do" to keep it open for the other issues reported in the comment: #7624 (comment)

@donnapep donnapep modified the milestones: 4.24.2, 4.24.3 Aug 7, 2024
@donnapep donnapep removed this from the 4.24.3 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants