Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course patterns have spacing set that don't work on mobile #6039

Open
yscik opened this issue Oct 27, 2022 · 2 comments
Open

Course patterns have spacing set that don't work on mobile #6039

yscik opened this issue Oct 27, 2022 · 2 comments

Comments

@yscik
Copy link
Contributor

yscik commented Oct 27, 2022

Many of the patterns offered for the course ('Long sales page', 'Video hero') have Group blocks with left-right padding attributes set to 90px or similar. These don't look to good on mobile screens:

image

<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"bottom":"120px","top":"120px","right":"90px","left":"90px"}} ... -->

Steps to reproduce

  • Add a course and select one of the patterns, or add them to an existing course
  • Open course frontend on a small screen

Notes

  • The Dimensions control in the block editor is not available on all themes (like classic themes, but even on TT1), so the users cannot change the padding or even see what sets it
  • Gutenberg is just shipping spacing presets that are responsive (ie the 'medium' preset would mean fewer pixels on mobile). See Spacing presets: add editor UI support WordPress/gutenberg#42173 and linked issues there
  • Group blocks have reasonable default paddings set when they have a background color, so I think the best action right now is to remove all the padding from the patterns and use the theme/WP default.
@m1r0
Copy link
Member

m1r0 commented Nov 30, 2022

5749810-zd-woothemes

@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 5749810-zen

@gikaragia gikaragia removed the [Status] Needs Triage Issue needs to be triaged label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants