Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group common scripts #44

Open
joshbetz opened this issue Jan 2, 2019 · 0 comments
Open

Group common scripts #44

joshbetz opened this issue Jan 2, 2019 · 0 comments

Comments

@joshbetz
Copy link
Contributor

joshbetz commented Jan 2, 2019

Concat can be a little overzealous in cases where a script or style is enqueued conditionally. Say a script is used on one page. Ideally we wouldn't serve a different Javascript bundle on that page that is the same as every other page with the one extra script added. The bundle that loads on every other page is most likely already cached in the user's browser. We really just need to serve the additional script separately (or maybe inline?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant