Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When WP_CONTENT_DIR is changed WPCOM_Concat_Utils::realpath fails #30

Open
drrobotnik opened this issue Mar 27, 2017 · 1 comment
Open

Comments

@drrobotnik
Copy link

Related to #28.

When you separate your WordPress install and the wp-content directory via WP_CONTENT_DIR realpath fails and will never concatenate your theme and plugin scripts. I started working on a patch but found that even when I got realpath to account for this set-up line 103 in jsconcat.php has conditionals that continue to break in this kind of set-up.

I discovered this in a multisite sub-domain install configuration, haven't tested on the default set-up.

@pdemaria
Copy link

pdemaria commented Oct 11, 2018

Second this, the plugin doesn't appear to work when Wordpress is simply installed in a subdirectory... 404s galore...

Probably a slicker way to work out pathing? Plus the nginx instructions are a little vague...

Granted, my nginx config was boilerplate Laravel Homestead >>> Laravel Forge... so it's entirely possible I've mangled it making other adjustments. Help?

emrikol added a commit that referenced this issue Jan 29, 2020
Allows `WP_CONTENT_DIR` to be a non-default value.

Hopefully will fix #30

Additionally includes some debugging information when `WP_DEBUG` is enabled that:

1. Includes the file handles in the output tags.
2. Adds HTML comments for files that are not concatenated explaining why.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants