cast limit & offest to intenger

[jimmywarting]

Hi, i was using URLSearchParams to fetch data with a GET request as a query filter

i didn't want to use json/post cuz i don't save anything and i wanted to take advantage of caching GET requests in browsers too, therefore i used URLSearchParams instead

but the thing was that it returns all numbers as a strings instead of numbers so when i did Collection.find({}).skip(x).limit(y) then i got a "FailedToParse" MongoDB error.

the simple solution was to cast them into numbers.
but i was thinking that it would be good if you did use parseInt in those two (skip & limit) functions too so that skip("2") just works

[vkarpov15]

@jimmywarting what version of Mongoose are you using? I checked and we do convert limit and skip to numbers here:

mongoose/lib/query.js

Lines 843 to 856 in a792dc3

	Query.prototype.limit = function limit(v) {
	this._validate('limit');
	if (typeof v === 'string') {
	try {
	v = castNumber(v);
	} catch (err) {
	throw new CastError('Number', v, 'limit');
	}
	}
	this.options.limit = v;
	return this;
	};

and here:

mongoose/lib/query.js

Lines 877 to 890 in a792dc3

	Query.prototype.skip = function skip(v) {
	this._validate('skip');
	if (typeof v === 'string') {
	try {
	v = castNumber(v);
	} catch (err) {
	throw new CastError('Number', v, 'skip');
	}
	}
	this.options.skip = v;
	return this;
	};

.

[jimmywarting]

^5.12.7

[vkarpov15]

@jimmywarting that explains the issue. You need to upgrade to Mongoose 6 for this feature.

[jimmywarting]

Gotcha