-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiled Gallery: Ensure container enclosing image is selectable #40779
base: trunk
Are you sure you want to change the base?
Conversation
…, to prevent Gutenberg conflicts
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
…ith a container div, which has a button role
…nclosing extra container
96dbbfb
to
04d2824
Compare
Fixes #40747
Issue and Proposed changes:
img
elements to the enclosingfigure
elements, and changing those fromfigure
todiv
's. This prevents the issue mentioned above, though adding the interactive elements to the enclosingdiv
is also not a perfect solution. I've added the role of button so that it makes more sense from an accessibility POV.aria-hidden="true"
property has been added to the anchor that encloses the Tiled Galleryimg
in the editor, as the link isn't meant to be functional there.For Follow-up:
Other information:
Jetpack product discussion
#40747
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
To test the original behavior:
To replicate the issue:
To test the fix:
Existing issues: