Remove unneeded filter handling

Author: dkmyta

projects/js-packages/components/components/threats-data-views/index.tsx

@@ -14,7 +14,7 @@ import {
 import { dateI18n } from '@wordpress/date';
 import { __ } from '@wordpress/i18n';
 import { Icon } from '@wordpress/icons';
-import { useCallback, useMemo, useState, useEffect } from 'react';
+import { useCallback, useMemo, useState } from 'react';
 import Badge from '../badge';
 import ThreatFixerButton from '../threat-fixer-button';
 import ThreatSeverityBadge from '../threat-severity-badge';
@@ -55,7 +55,6 @@ import ThreatsStatusToggleGroupControl from './threats-status-toggle-group-contr
  * @param {Function} props.isThreatEligibleForFix      - Function to determine if a threat is eligible for fixing.
  * @param {Function} props.isThreatEligibleForIgnore   - Function to determine if a threat is eligible for ignoring.
  * @param {Function} props.isThreatEligibleForUnignore - Function to determine if a threat is eligible for unignoring.
- * @param {Function} props.onStatusFilterChange        - Callback function run when the status filter changes.
  *
  * @return {JSX.Element} The ThreatsDataViews component.
  */
@@ -69,7 +68,6 @@ export default function ThreatsDataViews( {
 	onFixThreats,
 	onIgnoreThreats,
 	onUnignoreThreats,
-	onStatusFilterChange,
 }: {
 	data: Threat[];
 	filters?: Filter[];
@@ -80,7 +78,6 @@ export default function ThreatsDataViews( {
 	onFixThreats?: ( threats: Threat[] ) => void;
 	onIgnoreThreats?: ActionButton< Threat >[ 'callback' ];
 	onUnignoreThreats?: ActionButton< Threat >[ 'callback' ];
-	onStatusFilterChange?: ( newStatus: 'active' | 'historic' | null ) => void;
 } ): JSX.Element {
 	const baseView = {
 		sort: {
@@ -535,11 +532,6 @@ export default function ThreatsDataViews( {
 	 */
 	const getItemId = useCallback( ( item: Threat ) => item.id.toString(), [] );
 
-	// Notify the consumer whenever the selectedStatusFilter changes
-	useEffect( () => {
-		onStatusFilterChange?.( selectedStatusFilter );
-	}, [ selectedStatusFilter, onStatusFilterChange ] );
-
 	return (
 		<DataViews
 			actions={ actions }

projects/plugins/protect/src/js/routes/scan/index.jsx

@@ -1,5 +1,5 @@
 import { AdminSection, Container, Col } from '@automattic/jetpack-components';
-import { useMemo, useState, useCallback } from 'react';
+import { useMemo, useState } from 'react';
 import { useLocation, useParams } from 'react-router-dom';
 import AdminPage from '../../components/admin-page';
 import OnboardingPopover from '../../components/onboarding-popover';
@@ -8,7 +8,6 @@ import useScanStatusQuery, { isScanInProgress } from '../../data/scan/use-scan-s
 import useAnalyticsTracks from '../../hooks/use-analytics-tracks';
 import { OnboardingContext } from '../../hooks/use-onboarding';
 import usePlan from '../../hooks/use-plan';
-import HistoryAdminSectionHero from './history-admin-section-hero';
 import onboardingSteps from './onboarding-steps';
 import ScanAdminSectionHero from './scan-admin-section-hero';
 import ScanResultsDataView from './scan-results-data-view';
@@ -29,11 +28,6 @@ const ScanPage = () => {
 	const { data: history } = useHistoryQuery();
 
 	const [ scanResultsAnchor, setScanResultsAnchor ] = useState( null );
-	const [ statusFilter, setStatusFilter ] = useState( 'active' );
-
-	const handleStatusFilterChange = useCallback( newStatusFilter => {
-		setStatusFilter( newStatusFilter );
-	}, [] );
 
 	let currentScanStatus;
 	if ( status.error ) {
@@ -80,11 +74,7 @@ const ScanPage = () => {
 	return (
 		<OnboardingContext.Provider value={ onboardingSteps }>
 			<AdminPage>
-				{ 'historic' === statusFilter ? (
-					<HistoryAdminSectionHero />
-				) : (
-					<ScanAdminSectionHero size={ showResults ? 'normal' : 'large' } />
-				) }
+				<ScanAdminSectionHero size={ showResults ? 'normal' : 'large' } />
 				{ showResults && (
 					<AdminSection>
 						<Container
@@ -94,10 +84,7 @@ const ScanPage = () => {
 						>
 							<Col>
 								<div ref={ setScanResultsAnchor }>
-									<ScanResultsDataView
-										filters={ filters }
-										onStatusFilterChange={ hasPlan ? handleStatusFilterChange : null }
-									/>
+									<ScanResultsDataView filters={ filters } />
 								</div>
 								{ !! status && ! isScanInProgress( status ) && (
 									<OnboardingPopover

projects/plugins/protect/src/js/routes/scan/scan-results-data-view.tsx

@@ -8,18 +8,15 @@ import useModal from '../../hooks/use-modal';
 /**
  * Scan Results Data View
  *
- * @param {object}   props                      - Component props.
- * @param {Array}    props.filters              - Default filters to apply to the data view.
- * @param {Function} props.onStatusFilterChange - Callback function to handle status filter changes.
+ * @param {object} props         - Component props.
+ * @param {Array}  props.filters - Default filters to apply to the data view.
  *
  * @return {JSX.Element} ScanResultDataView component.
  */
 export default function ScanResultsDataView( {
 	filters = [],
-	onStatusFilterChange,
 }: {
 	filters: React.ComponentProps< typeof ThreatsDataViews >[ 'filters' ];
-	onStatusFilterChange: ( newStatus: 'active' | 'historic' | null ) => void;
 } ) {
 	const { setModal } = useModal();
 
@@ -54,7 +51,6 @@ export default function ScanResultsDataView( {
 			onFixThreats={ onFixThreats }
 			onIgnoreThreats={ onIgnoreThreats }
 			onUnignoreThreats={ onUnignoreThreats }
-			onStatusFilterChange={ onStatusFilterChange }
 		/>
 	);
 }