Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: "on course" is flagged to change to "of course" #770

Open
hippietrail opened this issue Feb 24, 2025 · 1 comment
Open

bug: "on course" is flagged to change to "of course" #770

hippietrail opened this issue Feb 24, 2025 · 1 comment
Labels
bug Something isn't working harper-core linting

Comments

@hippietrail
Copy link
Contributor

Description

"On course" is a normal, common English phrase but it's getting flagged. It's suggested to change it to a different English phrase with a completely different meaning "of course".

The problem is there's a linter for fixing "off course" when "of course" is meant but it's catching too many things. This might not happen if multi-word lexemes were in a dictionary. But changing the "off course" linter to fix only that one specific wrong term would work.

Screenshots

Image
@hippietrail hippietrail added bug Something isn't working harper-core linting labels Feb 24, 2025
elijah-potter added a commit that referenced this issue Feb 24, 2025
@elijah-potter
fix(core): address #770
0e8478e
@elijah-potter
Copy link
Collaborator

This should be fixed as of Harper v0.23.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working harper-core linting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hippietrail @elijah-potter