Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't ignore min #287

Open
benjaminjellis opened this issue Nov 27, 2024 · 2 comments
Open

Can't ignore min #287

benjaminjellis opened this issue Nov 27, 2024 · 2 comments

Comments

@benjaminjellis
Copy link

Harper flags min in docs as a misspelling. However, it only provides an action to correct the spelling to minute and doesn't provide an action to add min to the global / file dictionary.

I looked through the issues and it seems to be related to #243, as in , that issue notes ms also cannot be added to the global / file dictionary

Screenshot 2024-11-27 at 11 43 35
@grantlemons
Copy link
Contributor

This is because it is currently an explicit recommendation to use minute and not min, and isn't considered a spelling thing. There are a couple of changes we can probably make to improve this, but a temporary one is to add minimum as another way to correct min.

Not to be prescriptive about your comment, but the fix I would make in your shoes is just to say "minimum payment" instead of "min payment" in your doc comment, since saying that a field named min_payment is the "min payment" doesn't really clarify anything.

@benjaminjellis
Copy link
Author

Thanks! The snippet is just demonstration of the issue since I can't share any real code here

elijah-potter added a commit that referenced this issue Dec 3, 2024
fix(#287): add minimum as a correction from min
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants