Replace corrupts serialized data if the search and replace are of different length

[sjinks]

To reproduce:

php -r 'echo serialize("aaaaabbbbbbbbbbaaaaa"), PHP_EOL;' > test.txt
cat test.txt | ./go-search-replace bbbbbbbbbb ccccc
cat test.txt | ./go-search-replace bbbbbbbbbb ccccccccccccccc

Expected result:

s:15:"aaaaacccccaaaaa";
s:25:"aaaaacccccccccccccccaaaaa";

Actual result:

s:20:"aaaaacccccaaaaa";
s:20:"aaaaacccccccccccccccaaaaa";

[trepmal]

This is because go-search-replace expects the quote marks to be escaped. Whether that's a bug or not I don't know.

$ php -r 'echo addslashes( serialize("aaaaabbbbbbbbbbaaaaa") ), PHP_EOL;' > test.txt
$ cat test.txt                                                                    
s:20:\"aaaaabbbbbbbbbbaaaaa\";

$ cat test.txt | go-search-replace bbbbbbbbbb ccccc                               
s:15:\"aaaaacccccaaaaa\";

$ cat test.txt | go-search-replace bbbbbbbbbb ccccccccccccccc                     
s:25:\"aaaaacccccccccccccccaaaaa\";

[sjinks]

But then it does not work on statements like

INSERT INTO `wp_options` (option_name, option_value) VALUES ('test', 's:15:"aaaaacccccaaaaa";');

[sjinks]

Double quotes inside single quotes do not have to be escaped.

[joshbetz]

I think WP always escapes the quotes, but if you're seeing otherwise it should be fine to change the regex

https://github.com/Automattic/go-search-replace/blob/master/search-replace.go#L17-L18