Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle single-room mode when room is not available to user #181

Open
psrpinto opened this issue Feb 6, 2023 · 2 comments
Open

Comments

@psrpinto
Copy link
Member

psrpinto commented Feb 6, 2023

There are several scenarios that can result in the user not being able to access the configured room, in single-room mode:

  1. Room doesn't exist
  2. User can't access room
    • Because room is private
    • Because room is not under a Space the user has access to
    • etc
  3. Configured room alias doesn't resolve to a room

We should gracefully handle this case, by either:

  1. Showing an error screen
  2. Falling back to non-single-room mode
@ashfame
Copy link
Member

ashfame commented Feb 8, 2023

IMO, we should show an error screen in such cases and not try to render the client at all. Single room mode is about a specific room's chat access directly and never a generic client to find the room other than the specified one.

@ashfame
Copy link
Member

ashfame commented Mar 7, 2023

@psrpinto and I discussed it would be better to just fail the client if room resolution fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants