`is_rtl` considered harmful

[simonwheatley]

Currently our is_rtl function parses (eugh) any locale file and checks for RTL. Instead we should just hardcode the RTL languages into an array (really, how often is a new one going to come along), and allow the dev to filter it so they can add any special case they may require.

[markoheijnen]

Why do we have is_rtl? Is this value needed or can it be dealt with on runtime?

[simonwheatley]

See this issue suggesting using Glotpress' locale class, which @hewsut has also just suggested: #76

Also relevant, this PR from December to add language install capabilities: #201

[simonwheatley]

Why do we have is_rtl? Is this value needed or can it be dealt with on runtime?

I think this is just so we can have the information in the available languages screen. At runtime it's dealt with by loading the language locale information, not doing some crazy parsing of PHP to avoid loading it. 😄

[markoheijnen]

I thought so, so if it's only for showing information then why bot removing it? I assume the user would know if the language is RTL or not 😉

[simonwheatley]

Removing it is another solution. Thinking.

[simonwheatley]

Hard coding a list of languages in Babble in some way, seems best.