Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder for empty display_name #2789

Open
joewa1980 opened this issue Mar 18, 2024 · 0 comments
Open

Placeholder for empty display_name #2789

joewa1980 opened this issue Mar 18, 2024 · 0 comments

Comments

@joewa1980
Copy link

In the file wp-job-manager-alerts/includes/emails/class-job-alert-email.php I'd suggest line 352 is changed from:

'{display_name}' => $user->display_name ?? $user->user_email,
to
'{display_name}' => !empty($user->display_name) ? $user->display_name : 'there',

...this will stop an alert going out to a user without a display name set (for whatever reason) and rendering a space where the display name would be:

Before:
"Hi ,"

After:
"Hi there,"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant