Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear which users can/can't receive post notifications #451

Closed
WPprodigy opened this issue Apr 5, 2018 · 3 comments
Closed

Make it clear which users can/can't receive post notifications #451

WPprodigy opened this issue Apr 5, 2018 · 3 comments

Comments

@WPprodigy
Copy link
Contributor

WPprodigy commented Apr 5, 2018

Extracting the second part of #265 to a new issue. This comes after #449 and ideally before/alongside #273.

Only users that are able to view & edit a post will be receiving editorial comment and status change notification emails. But at the moment, users that do not have the edit_post privilege for specific post can still be signed up for notifications and the editor/author may not be aware that the person won't be receiving notifications.

In #273, there will need to be a way to grant or at least show that a user is being given extra privileges by being selected for notifications. So this issue can start off the process with a basic implementation of just showing who can/can't receive notifications, then 273 can take it further with the needed functionality.

After some discussions, the consensus was that it would be best to do the permissions validation via ajax when the user is selected - rather than doing it for every user during page load. This is for scaling reasons, at least if/until we stop loading all users all at once.

So with that in mind, I'm thinking it should be something like this: http://cld.wthms.co/n3SUyc. This way, it only needs to run the permissions check when the user is being selected or if the user is already selected. Then the UI changes in 273 would simply be changing the label to "Access Granted" perhaps automatically or with the click of a button :)

no-access

Thoughts? @jerclarke @sboisvert

@jerclarke
Copy link
Contributor

I think the premise is good and if it worked like this it would help a lot of people.

Maybe it could say "[No Access (?)]" with the (?) being a hover popup that explains that the user won't get notifications nor be able to log in.

@WPprodigy
Copy link
Contributor Author

WPprodigy commented Apr 9, 2018

Maybe it could say "[No Access (?)]" with the (?) being a hover popup that explains that the user won't get notifications nor be able to log in.

I like the idea, but the long-term plan is tentatively to make it so clicking on "No Access" grants the user special access (which will be a green badge with "Access Granted" for example). So probably not worth the effort of the tooltips with that in mind, imo.


Also worth noting that this will also affect the two PRs in #270. The "who was/will be notified" messages should look for this "no access" badge and adjust accordingly.

@WPprodigy
Copy link
Contributor Author

Closing, #449 is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants