Sprint Drei (#896)

Author: HunterBarclay

.github/workflows/API.yml

@@ -1,6 +1,7 @@
 name: API
 
 on:
+  workflow_dispatch: {}
   push:
     branches: [ master, dev ]
   pull_request:

.github/workflows/ClangFormat.yml

@@ -2,7 +2,7 @@ name: Format Validation (Clang)
 
 on:
   workflow_dispatch: {}
-  push: 
+  push:
     branches: [ master, dev ]
   pull_request:
     branches: [ master, dev ]
@@ -12,12 +12,12 @@ jobs:
     name: Run Clang Format Validation Script
     runs-on: ubuntu-latest
     steps:
-    - name: Get Clang Format
+    - name: Get Clang Format 16
       run: |
+        sudo wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
+        sudo add-apt-repository "deb http://apt.llvm.org/jammy/  llvm-toolchain-jammy-16 main"
         sudo apt-get update
-        sudo apt-get install --no-install-recommends -y
-        sudo apt-get install clang-format-15
-        sudo mv /usr/bin/clang-format-15 /usr/bin/clang-format
+        sudo apt-get install -y clang-format-16
     - name: Checkout Code
       uses: actions/checkout@v2
     - name: Python Setup

api/Api/AssetManager/AudioClipAsset.cs

@@ -3,6 +3,8 @@
 using UnityEngine;
 using UnityEngine.Networking;
 
+#nullable enable
+
 namespace SynthesisAPI.AssetManager
 {
     public class AudioClipAsset : Asset
@@ -15,6 +17,11 @@ public class AudioClipAsset : Asset
         public AudioClipAsset(string name, Permissions perm, string sourcePath)
         {
             Init(name, perm, sourcePath);
+
+            // create empty clip
+            _clip = AudioClip.Create("EmptyClip", 44100, 1, 44100, false);
+            float[] data = new float[44100];
+            _clip.SetData(data, 0);
         }
 
         public override IEntry Load(byte[] data)

api/Api/EnvironmentManager/Components/BundleMarker.cs

@@ -1,8 +1,14 @@
 using System;
 using SynthesisAPI.Modules.Attributes;
 
+#nullable enable
+
 namespace SynthesisAPI.EnvironmentManager.Components {
     public class BundleMarker : Component {
         public string Name { get; set; }
+
+        public BundleMarker() {
+            Name = "";
+        }
     }
-}
+}

api/Api/EnvironmentManager/Components/Joints.cs

@@ -6,6 +6,8 @@
 using System.Runtime.CompilerServices;
 using System.Text;
 
+#nullable enable
+
 namespace SynthesisAPI.EnvironmentManager.Components
 {
     /// <summary>
@@ -17,10 +19,10 @@ public class Joints : Component
         private static List<Joints> _allJointContainers = new List<Joints>();
 
         public delegate void JointChanged(IJoint joint);
-        public static event JointChanged GlobalAddJoint;
-        internal event JointChanged AddJoint;
-        public static event JointChanged GlobalRemoveJoint;
-        internal event JointChanged RemoveJoint;
+        public static event JointChanged? GlobalAddJoint;
+        internal event JointChanged? AddJoint;
+        public static event JointChanged? GlobalRemoveJoint;
+        internal event JointChanged? RemoveJoint;
 
         private List<IJoint> _joints = new List<IJoint>();
         public List<IJoint> AllJoints {
@@ -68,7 +70,7 @@ public override bool Equals(object obj) {
             if (!(obj is Joints))
                 return false;
 
-            return (obj as Joints).GetHashCode() == GetHashCode();
+            return (obj as Joints)?.GetHashCode() == GetHashCode();
         }
         public override int GetHashCode() => _guid.GetHashCode();
     }

api/Api/EventBus/Analytics.cs

@@ -4,6 +4,8 @@
 using System.Threading;
 using System.Threading.Tasks;
 
+#nullable enable
+
 namespace SynthesisAPI.EventBus
 {
     public static class Analytics
@@ -522,7 +524,7 @@ private Inner()
                 StartTimes = new List<KeyValuePair<string, float>>();
             }
 
-            private static Inner _inst;
+            private static Inner? _inst;
             public static Inner InnerInstance => _inst ??= new Inner();
         }
         private static Queue<KeyValuePair<string, string>> LoggedData => Instance.LoggedData;

api/Api/EventBus/EventBus.cs

@@ -181,8 +181,8 @@ public static void ResetAllListeners()
                 if (AppDomain.CurrentDomain.GetAssemblies()
                     .Any(a => a.FullName.ToLowerInvariant().StartsWith("nunit.framework")))
                 {
-                    _inst.TypeSubscribers = new Dictionary<string, EventCallback>();
-                    _inst.TagSubscribers = new Dictionary<string, EventCallback>();
+                    _inst!.TypeSubscribers = new Dictionary<string, EventCallback>();
+                    _inst!.TagSubscribers = new Dictionary<string, EventCallback>();
                 }
                 else
                 {
@@ -205,5 +205,4 @@ private Inner()
 
         private static Inner Instance => Inner.InnerInstance;
     }
-
 }

api/Api/InputManager/Inputs.cs

@@ -8,6 +8,8 @@
 using Logger = UnityEngine.Logger;
 using Math = System.Math;
 
+#nullable enable
+
 namespace SynthesisAPI.InputManager.Inputs
 {
     // TODO: Should I add HashCodes?
@@ -77,7 +79,7 @@ public virtual Analog WithModifier(int newMod)
         public override bool Equals(object obj) {
             if (ReferenceEquals(obj, null) || !(obj is Analog))
                 return false;
-            return (obj as Analog).GetHashCode() == GetHashCode();
+            return (obj as Analog)?.GetHashCode() == GetHashCode();
         }
 
         public override int GetHashCode()
@@ -147,7 +149,7 @@ public override Analog WithModifier(int newMod)
         public override bool Equals(object obj) {
             if (ReferenceEquals(obj, null) || !(obj is Digital))
                 return false;
-            return (obj as Digital).GetHashCode() == GetHashCode();
+            return (obj as Digital)?.GetHashCode() == GetHashCode();
         }
 
         public override int GetHashCode()

api/Api/Mirabuf/Appearance.cs

@@ -4,9 +4,11 @@
 
 using Logger = SynthesisAPI.Utilities.Logger;
 
+#nullable enable
+
 namespace Mirabuf.Material {
     public partial class Appearance {
-        private UMaterial _unityMaterial = null;
+        private UMaterial? _unityMaterial = null;
         public UMaterial UnityMaterial {
             get {
                 if (_unityMaterial == null) {
@@ -53,7 +55,7 @@ public UMaterial UnityMaterial {
         public const string OPAQUE_COLOR = "Color_2aa135b32e7e4808b9be05c544657380";
         public const string OPAQUE_SMOOTHNESS = "Vector1_dd87d7fcd1f1419f894566001d248ab9";
         public const string OPAQUE_METALLIC = "OPAQUE_METALLIC";
-        private static Shader _defaultOpaqueShader = null;
+        private static Shader? _defaultOpaqueShader = null;
         public static Shader DefaultOpaqueShader {
             get {
                 if (_defaultOpaqueShader == null) {
@@ -64,7 +66,7 @@ public static Shader DefaultOpaqueShader {
         }
         public const string TRANSPARENT_COLOR = "Color_48545d7793c14f3d9e1dd2264f072068";
         public const string TRANSPARENT_SMOOTHNESS = "Vector1_d66a0e8b289a457c85b3b4408b4f3c2f";
-        private static Shader _defaultTransparentShader = null;
+        private static Shader? _defaultTransparentShader = null;
         public static Shader DefaultTransparentShader {
             get {
                 if (_defaultTransparentShader == null) {

api/Api/Mirabuf/SimpleMotor.cs

@@ -6,15 +6,14 @@ namespace Mirabuf.Motor {
     public partial class SimpleMotor {
 
         // Extremely arbitrary
-        public const float METRIC_TO_UNITY_TORQUE = 2000f / 50f;
 
         private UnityEngine.JointMotor? _unityMotor;
         public UnityEngine.JointMotor UnityMotor {
             get {
                 if (!_unityMotor.HasValue) {
                     _unityMotor = new UnityEngine.JointMotor {
-                        force = StallTorque * METRIC_TO_UNITY_TORQUE,
-                        targetVelocity = MaxVelocity * UnityEngine.Mathf.Rad2Deg,
+                        force = StallTorque,
+                        targetVelocity = MaxVelocity,
                         freeSpin = BrakingConstant > 0
                     };
                 }