Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A stable and robust BC added for stationary and moving curved BCs #68

Merged
merged 18 commits into from
Oct 5, 2024

Conversation

hsalehipour
Copy link
Collaborator

  1. Added a stable and robust BC for stationary and moving curved BCs which is a hybrid between differentiable interpolated bouceback and the Grads Approximation and the Regularization methods. Preliminary tests indicate stable resutls for exceedingly high Re values using the wind tunnel example.

  2. Added a new boundary masker that also provides fractional distance to the mesh used in the above boundary for curved geometries.

  3. Made major changes to the inputs and outputs of BC functionals by passing in entire f_0 and f_1 fields as well as the index. So all the auxiliary data are now build and constructed (if needed) inside the BC class.

  4. The above change coincidently removed the perf drop experienced by going from Warp 1.3 to 1.4

  5. Existing Perf Drop: I am seeing about 38%!!! perf drop (2780 vs 4448 MLUPS) due to these 3 lines in nse_stepper.py using Warp 1.4 on my A6000 GPU!

if _boundary_id == bc_struct.id_GradsApproximationBC:
                    if _missing_mask[l] == wp.uint8(1):
                        f_0[_opp_indices[l], index[0], index[1], index[2]] = self.store_dtype(f1_thread[_opp_indices[l]])

@hsalehipour hsalehipour requested a review from mehdiataei October 3, 2024 21:15
@mehdiataei
Copy link
Contributor

mehdiataei commented Oct 5, 2024

This looks great. Thanks. There are some small cosmetic issues that will be fixed in my next PR. Nothing significant.

@mehdiataei mehdiataei merged commit a50fbbd into Autodesk:major-refactoring Oct 5, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants