Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We're calculating pressure and velocity incorrectly in the Warp backend. #90

Closed
mehdiataei opened this issue Nov 7, 2024 · 1 comment

Comments

@mehdiataei
Copy link
Contributor

mehdiataei commented Nov 7, 2024

Since we're using the pull method, a must apply one streaming step (plus, apply_bc poststreaming) before calculating rho and u.

@mehdiataei mehdiataei changed the title We're calculating pressure and velocity incorrectly. We're calculating pressure and velocity incorrectly in the Warp backend. Nov 7, 2024
@hsalehipour
Copy link
Collaborator

that's not quite right. The zero'th and first moment of the Collision operation is zero actually and so the only issue we have with the way we are outputting rho and vel is at the boundaries and so all we need to be cautious of is not to include boundary voxels in our viz and analysis unless it is needed in our analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants