fixed a few 2D bugs #85
Conversation
|
I'll wait for you to push other changes. One comment for now is to squash your commits with a better description on your end. |
| return -_u_vec(_c_float[0, l], _c_float[1, l], _c_float[2, l]) | ||
| if wp.static(_d == 3): | ||
| for l in range(_q): | ||
| if missing_mask[l] == wp.uint8(1) and wp.abs(_c[0, l]) + wp.abs(_c[1, l]) + wp.abs(_c[2, l]) == 1: |
There was a problem hiding this comment.
This does not make sense. As we only have 3D vectors in Warp.
There was a problem hiding this comment.
That's not true. The lattice velocity "c" is still represents a 2D vector per each lattice dimenion for a 2D lattice and a 3D vector per each lattice dimension for a 3D lattice.
| else: | ||
| for l in range(_q): | ||
| if missing_mask[l] == wp.uint8(1) and wp.abs(_c[0, l]) + wp.abs(_c[1, l]) == 1: | ||
| return -_u_vec(_c_float[0, l], _c_float[1, l]) |
There was a problem hiding this comment.
We're not working with 2D vectors anymore in the Warp backend and their use should be avoided. The vectors shouldn't depend on the grid dimension. I guess this is being done because this is a normal. But the fix should be done more fundamentally to avoid downstream issues.
For example in 2D, you may have only (1,0,0) and (0,1,0),...Why would this not be working? I think the change should be down in the code that utilizes this normals later.
There was a problem hiding this comment.
Please see the above comment.
Contributing Guidelines
Description
test_bc_indices_masker_warp.py. This PR fixes that.Type of change
How Has This Been Tested?
Linting and Code Formatting
Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.
To run Ruff, execute the following command from the root of the repository:
ruff check .