-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallpaper immediately switches back sometimes #800
Comments
Sure I've enabled the trace mode and had it do a switch, I'll put the log below. In this case it was from light to dark mode, and the wallpaper switched back to the light wallpaper. And both wallpaper 'type' settings were set to 'Picture'.
I'd try a beta version but on my computer I have Smart App Control enabled which wouldn't let me run unsigned files that don't have a reputation so I probably can't. |
Ah you're right, I am able to run the version from the beta channel so I could let you know how any fix works if implemented. Not that it needs to be a priority or anything since it's easy enough to work around, and seems to be an edge case anyway. |
I will second this issue, actually. And this beta didn't seem to fix the issue for me. In my situation, I switch from dark mode to light mode, and everything works correctly. But when I switch back to dark mode, everything changes correctly, including the background, but the background then immediately switches back to the light mode background. |
Please don't do comments like "i have this issue too" because it will unnecessarily alert everyone that is subscribed to this issue. This is a confirmed bug and for now we've collected all the data we need to fix it. As far as the beta build is concerned: Thanks |
I have pushed an update that addresses incorrect behavior of the global (single monitor) wallpaper. This should hopefully also resolve this issue. Please update to the latest 10.4.2.4 using the beta update channel and let me know if it works. |
I can confirm that this appears to be fixed on my end. |
Yep for me with 10.4.2.4 it seems to be fixed as well 👍 Feel free to close the issue whenever, I'll leave it open myself since I'm not sure if you typically prefer to close them after fixes are pushed to stable as opposed to pre-release. |
I encountered the same problem, found this issue and updated to 10.4.2.5 beta, but it fixed the bug onlu partially. I have 3 virtual desktops on 2-monitor configuration, the problem is that in this version the correct change of wallpaper happens only for active virtual desktop (on both monitors). I use one image for all monitors option. |
Thats unrelated to this issue. It's simply a Windows api limitation. We have an different issue to track this, see here for more info: #469 I'll close this one as the original problem has been resolved. |
Description
I've come across some odd behavior where under some conditions, the chosen wallpaper for a light/dark mode will immediately switch back after ADM switches between light/dark mode. The system theme correctly sticks, but the wallpaper doesn't. See the attached video at the bottom where I also describe what's going on in the video.
Expected Behavior
When switching between themes, the selected wallpaper will stay after switching.
Log Data
Here are the logs that occur during the video:
Config file when both types are set to 'Picture' and problem occurs:
Config file when both types are set to "Picture (Multiple Monitors)" and it behaves as expected:
Commit Hash, Version and Windows Build
cf7a0fe
10.4.1.1
3.1.4
1.3.3.0
7.0.5
22631.2787
Screenshots / Videos
Google drive link to video because it's too big for GitHub: https://drive.google.com/file/d/1zqAvqSFZxeo-hlJq3lwf51lFTdz6hOno/view?usp=sharing
Here is a description of what's going on in the video:
0:00 - Showing wallpaper settings for dark & light themes. The system is currently set to dark mode.
0:07 - I use a hotkey combo to force switch to light mode, but as you can see the wallpaper immediately switches back to my dark wallpaper (I have two monitors, and it does the same for the other monitor which is not visible in the recording). However the overall system theme correctly stays light.
0:13 - I use a hotkey to switch back to dark mode
0:17 - Again I repeat the demo of switching to light mode and once again the wallpaper switches back immediately
0:22 - I switch back to dark mode
0:26 - I change the Dark Theme wallpaper 'type' setting to
Picture (Multiple Monitors)
, and show the image path set for each monitor0:34 - I show that the Light Theme mode wallpaper type is still set to 'Picture'
0:37 - I use a hotkey to switch system to light mode, and wallpaper continues to switch back
0:43 - I switch back to dark mode
0:49 - I change the Light Theme wallpaper type to
Picture (Multiple Monitors)
, and show the setting for each wallpaper again0:57 - I use the hotkey to switch to light mode, and the wallpaper now correctly stays on the light one
1:03 - I switch back to dark mode and the wallpaper correctly switches to the dark wallpaper
1:08 - I switch the Light Theme 'type' setting back to
Picture
, then use the hotkey to switch to light mode, and the wallpaper correctly stays as the light one1:18 - I switch back to dark mode
1:24 - I switch the Dark Theme type setting to
Picture
, then use the hotkey to switch to light mode, but the wallpaper immediately switches back to the dark one1:33 - I switch back to dark mode
Summary:
Notes:
The text was updated successfully, but these errors were encountered: