Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: incorrect use_unverified_ssl variable usage #20

Open
figroc opened this issue Nov 29, 2023 · 0 comments
Open

Bug: incorrect use_unverified_ssl variable usage #20

figroc opened this issue Nov 29, 2023 · 0 comments

Comments

@figroc
Copy link

figroc commented Nov 29, 2023

Description

https://github.com/Authing/authing-py-sdk/blob/0e0e0aa82e500f5667aa8b26e1a00e11720b7c2b/authing/http/ManagementHttpClient.py#L12C62-L12C62

https://github.com/Authing/authing-py-sdk/blob/0e0e0aa82e500f5667aa8b26e1a00e11720b7c2b/authing/http/ManagementHttpClient.py#L35C14-L35C14

Minimal code-snippet showcasing the problem

        self.use_unverified_ssl = use_unverified_ssl or FALSE
        ...
        verify = not self.use_unverified_ssl
        r = requests.request(..., verify=verify, ...)

not FALSE is False

Expected behavior

respect the https verification requirement

Actual behavior

/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py:1099: InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.authing.cn'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#tls-warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant