Life changes #19560
Open
Life changes #19560
+347
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!wip Collidewith refactor have to go in first |
BotBOREALIS
added
the
WIP
1 task
FluffyGhoster
added
⚠ High Risk
|
!review |
BotBOREALIS
added
Review Required
and removed
WIP
Arrow768
reviewed
Jun 30, 2024
| if(LAZYLEN(spell_masters)) | ||
| for(var/obj/screen/movable/spell_master/spell_master in spell_masters) | ||
| spell_master.update_spells(0, src) | ||
|
|
||
| if(stat != DEAD) | ||
| return TRUE |
There was a problem hiding this comment.
The meaning of the returned value should be documented.
There was a problem hiding this comment.
It was supposed to be TRUE for "yes i am alive and processing" and FALSE or null for "i'm dead" but the Life procs are too inconsistent for it to be reliable, and I'm not rewriting them all to be at the moment
Note that this isn't different than other implementations of Life() that are already in the codebase, where they return TRUE at the end of it and null or FALSE otherwise, see eg. /mob/living/simple_animal/Life that returns a straight 1
Arrow768
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored Life() to receive seconds per tick and times fired as parameters.
Life() now cannot be slept in, turned various sleepings into async calls procs.
Optimized mob AI subsystems, gave them new priorities levels and flags.
Grab upgrades are now elaborated asynchronously, tweaked them to avoid stacking multiple upgrades.
Fixed plains tyrants keeping sending messages about stomping even if dead.