Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sportsbook: Don't show the remaining balances from LP removals #1487

Open
matt-bullock opened this issue Oct 18, 2021 · 2 comments
Open

Sportsbook: Don't show the remaining balances from LP removals #1487

matt-bullock opened this issue Oct 18, 2021 · 2 comments
Assignees
Labels
good first issue Good for newcomers UI
Milestone

Comments

@matt-bullock
Copy link

No description provided.

@JohnDanz
Copy link
Member

this will require an update to graph data so we can differentiate what was shares from a bought/sold position and what is shares from lp add/remove. adding bruno to track this.

@bthaile bthaile added the good first issue Good for newcomers label Oct 28, 2021
@bthaile
Copy link
Contributor

bthaile commented Oct 28, 2021

There are flags on the graph data and on the user's position that indicated if the user got a position from LPing.
positionFromAddLiquidity and positionFromRemoveLiquidity for positions that come from getUserBalances.

The graph schema also has these flags for closed positions. These flags would need to be added to the positionBalance graph query in queries.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers UI
Projects
None yet
Development

No branches or pull requests

4 participants