Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] More HDDVD info in medainfo #299

Open
LostRager opened this issue Jan 24, 2025 · 10 comments · Fixed by #301
Open

[Enhancement] More HDDVD info in medainfo #299

LostRager opened this issue Jan 24, 2025 · 10 comments · Fixed by #301

Comments

@LostRager
Copy link

LostRager commented Jan 24, 2025

Heyo/

I've made a request for mediainfo to add more info to hddvd's, but it will probably not be done. Or it if is it will take a long time.
MediaArea/MediaInfo#1013

Any chance you could add it as a feature to the UA so it injects the info into the mediainfo file when it does the parsing?
Also currently it just searches for largest .evo file, but most movies are split, so it would be nice if it could add the mediainfo for all parts.

For movies all the ones i've seen either starts with feature*.evo or pevob*.evo and if it does not start with that it should look for largest size.

@Audionut
Copy link
Owner

Even if they updated this, still need the existing language issue to be sorted before UA can update.

I'll have to hunt down some HDDVD to make any changes.

@Audionut
Copy link
Owner

What are you looking for with the combination of MI for all parts, just an accurate runtime?

@LostRager
Copy link
Author

LostRager commented Jan 25, 2025

What are you looking for with the combination of MI for all parts, just an accurate runtime?

Yeah, accurate runtime was my goal with that.

Injecting the correct time also works tho.

@Audionut
Copy link
Owner

Yeah, the existing code does scan each EVO, but dumps as seperate track in the meta. Issue sprung immediately since the existing audio path expects the first audio track at track 2 in MI, but that's not the case with how multiple EVOs are being inserted into the meta, and/or the second SD video track.

The HDDVD playlist is super rich and has all of the information.

Upon initial checks, seems the best solution is to just overwrie duration and size in the first MI, since everything else will be the same.

I'll work on parsing language info from the playlist, and probably chapter info also.

@Audionut Audionut mentioned this issue Jan 25, 2025
@Audionut
Copy link
Owner

I've only a single source atm, but the linked PR seems to satisfy the requirements here.

The disc I have doesn't have language info in the MI (see ATH (29452)), but I'll look at that later.

@LostRager
Copy link
Author

Here are some i just tried with the pr. LST 71019, 71020, 71021.

For some reason the sub info is not in the first part but in the second part mediainfo for 71020 and 21.

@Audionut
Copy link
Owner

It clearly grabbed the wrong playlist on 71019 also.

Have in client, will look tomorrow.

@Audionut
Copy link
Owner

Audionut commented Jan 28, 2025

Not quite the same source, but still same issues (in the source):

71351 / 71355

@LostRager
Copy link
Author

Nice, getting closer. Tried 3 more disks. 71420 | 71421 | 71422

@Audionut
Copy link
Owner

Audionut commented Feb 4, 2025

Pushing existing code as I need a clean synced state to ensure #316 goes as smoothly as possible.

If I understand correctly, the existing issue is that all of the associated playlist item tracks are still not being captured correctly, particularly in the mediainfo output?

I plan to handle this better at a later date, where I'll also merge DVD mediainfo so that MI boxes on site, better reflect the actual content, without having the look at both ifo/vob mi's. cbf'd working out how to fix the mediainfo code, and they don't seem overly interested, so will just merge the correct info here instead.

@Audionut Audionut reopened this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants