Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Enviroment Variables Support #105

Open
Middlepepper opened this issue Oct 26, 2024 · 1 comment
Open

Add Docker Enviroment Variables Support #105

Middlepepper opened this issue Oct 26, 2024 · 1 comment
Labels
PR welcome Will accept pull request

Comments

@Middlepepper
Copy link

Middlepepper commented Oct 26, 2024

This is more a Enhancement request but would it be worth while to setup Docker Variable pass-through?

I'm not sure how to do this so it will play nice with local variable while still letting someone manually edit the config.py

But I've done something similar to below, in another project.

  • i.e ACM api key = os.getenv('ACM api key') or
  • ACM announce_url = os.getenv('ACM announce_url')
@Audionut
Copy link
Owner

Audionut commented Oct 26, 2024

I don't do docker. Any docker modifications other than what is strictly necessary to make builds, needs to be submitted through a PR.

@Audionut Audionut added the PR welcome Will accept pull request label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR welcome Will accept pull request
Projects
None yet
Development

No branches or pull requests

2 participants