From 21314271aeffa001cac56e81c3b8feb5b944349d Mon Sep 17 00:00:00 2001 From: BuildTools Date: Thu, 5 Mar 2020 20:14:53 -0600 Subject: [PATCH 1/5] Add condition for classic PNG folders --- src/aocharmovie.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/aocharmovie.cpp b/src/aocharmovie.cpp index 6aa6e35ee..e84c493f7 100644 --- a/src/aocharmovie.cpp +++ b/src/aocharmovie.cpp @@ -21,6 +21,7 @@ void AOCharMovie::play(QString p_char, QString p_emote, QString emote_prefix) apng = false; QString original_path = ao_app->get_character_path(p_char, emote_prefix + p_emote + ".gif"); QString alt_path = ao_app->get_character_path(p_char, emote_prefix + p_emote + ".png"); + QString alt_path_still = ao_app->get_character_path(p_char, p_emote + ".png"); QString apng_path = ao_app->get_character_path(p_char, emote_prefix + p_emote + ".apng"); QString placeholder_path = ao_app->get_theme_path("placeholder.gif"); QString placeholder_default_path = ao_app->get_default_theme_path("placeholder.gif"); @@ -36,6 +37,8 @@ void AOCharMovie::play(QString p_char, QString p_emote, QString emote_prefix) gif_path = original_path; else if (file_exists(alt_path)) gif_path = alt_path; + else if (file_exists(alt_path_still)) + gif_path = alt_path_still; else if (file_exists(placeholder_path)) gif_path = placeholder_path; else From b9aba6207122f1dd4ab466eeb298b4d2c195603d Mon Sep 17 00:00:00 2001 From: BuildTools Date: Thu, 5 Mar 2020 23:01:40 -0600 Subject: [PATCH 2/5] added file to .gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 7d8fd4e7f..853070061 100644 --- a/.gitignore +++ b/.gitignore @@ -4,6 +4,7 @@ *.dll *.so *.pro.autosave +*.pro.user base_override.h .DS_Store From 27a101d01083abaf880fcc336f83a0e4426d5127 Mon Sep 17 00:00:00 2001 From: sD Date: Fri, 6 Mar 2020 17:14:42 +0100 Subject: [PATCH 3/5] fix compiler warnings for unused vars --- src/aoblipplayer.cpp | 4 ++-- src/aocharmovie.cpp | 1 - src/aooptionsdialog.cpp | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/aoblipplayer.cpp b/src/aoblipplayer.cpp index 1c668ab40..7929b7314 100644 --- a/src/aoblipplayer.cpp +++ b/src/aoblipplayer.cpp @@ -23,7 +23,7 @@ void AOBlipPlayer::set_blips(QString p_sfx) void AOBlipPlayer::blip_tick() { - int f_cycle = m_cycle++; + m_cycle++; if (m_cycle == 5) m_cycle = 0; @@ -70,7 +70,7 @@ void AOBlipPlayer::set_blips(QString p_sfx) void AOBlipPlayer::blip_tick() { - int f_cycle = m_cycle++; + m_cycle++; if (m_cycle == 5) m_cycle = 0; diff --git a/src/aocharmovie.cpp b/src/aocharmovie.cpp index e84c493f7..dfd535591 100644 --- a/src/aocharmovie.cpp +++ b/src/aocharmovie.cpp @@ -208,7 +208,6 @@ void AOCharMovie::play_pre(QString p_char, QString p_emote, int duration) m_movie->stop(); m_movie->setFileName(gif_path); m_movie->jumpToFrame(0); - int real_duration = 0; play_once = true; play(p_char, p_emote, ""); } diff --git a/src/aooptionsdialog.cpp b/src/aooptionsdialog.cpp index 37d495739..3749b6537 100644 --- a/src/aooptionsdialog.cpp +++ b/src/aooptionsdialog.cpp @@ -244,7 +244,6 @@ AOOptionsDialog::AOOptionsDialog(QWidget *parent, AOApplication *p_ao_app) : QDi ui_audio_device_combobox = new QComboBox(ui_audio_widget); // Let's fill out the combobox with the available audio devices. Or don't if there is no audio - int a = 0; if (needs_default_audiodev()) { @@ -253,6 +252,7 @@ AOOptionsDialog::AOOptionsDialog(QWidget *parent, AOApplication *p_ao_app) : QDi } #ifdef BASSAUDIO BASS_DEVICEINFO info; + int a = 0; for (a = 0; BASS_GetDeviceInfo(a, &info); a++) { ui_audio_device_combobox->addItem(info.name); From 2701fab91fcc417ba8e219054d0fa3e109b2e64a Mon Sep 17 00:00:00 2001 From: sD Date: Fri, 6 Mar 2020 17:14:49 +0100 Subject: [PATCH 4/5] indentation --- src/networkmanager.cpp | 4 ++-- src/packet_distribution.cpp | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/networkmanager.cpp b/src/networkmanager.cpp index a9810d49c..b029eabe1 100644 --- a/src/networkmanager.cpp +++ b/src/networkmanager.cpp @@ -134,9 +134,9 @@ void NetworkManager::on_srv_lookup() for (const QDnsServiceRecord &record : srv_records) { -#ifdef DEBUG_NETWORK + #ifdef DEBUG_NETWORK qDebug() << "Connecting to " << record.target() << ":" << record.port(); -#endif + #endif ms_socket->connectToHost(record.target(), record.port()); QTime timer; timer.start(); diff --git a/src/packet_distribution.cpp b/src/packet_distribution.cpp index d1c51bdf8..5e17542d4 100644 --- a/src/packet_distribution.cpp +++ b/src/packet_distribution.cpp @@ -564,11 +564,11 @@ void AOApplication::server_packet_received(AOPacket *p_packet) { if (courtroom_constructed) w_courtroom->reset_music_list(); - for (int n_element = 0 ; n_element < f_contents.size() ; ++n_element) - { - w_courtroom->append_music(f_contents.at(n_element)); - } - w_courtroom->list_music(); + for (int n_element = 0 ; n_element < f_contents.size() ; ++n_element) + { + w_courtroom->append_music(f_contents.at(n_element)); + } + w_courtroom->list_music(); } else if (header == "BN") { From 80bf49ee90e996c9f356d438231f941bad118b52 Mon Sep 17 00:00:00 2001 From: sD Date: Fri, 6 Mar 2020 22:14:59 +0100 Subject: [PATCH 5/5] ok bass --- src/aoblipplayer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/aoblipplayer.cpp b/src/aoblipplayer.cpp index 7929b7314..9b548c333 100644 --- a/src/aoblipplayer.cpp +++ b/src/aoblipplayer.cpp @@ -23,7 +23,7 @@ void AOBlipPlayer::set_blips(QString p_sfx) void AOBlipPlayer::blip_tick() { - m_cycle++; + int f_cycle = m_cycle++; if (m_cycle == 5) m_cycle = 0;