Skip to content
This repository was archived by the owner on Aug 7, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AtomLinter/linter-sass-lint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.7.2
Choose a base ref
...
head repository: AtomLinter/linter-sass-lint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Loading
129 changes: 129 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
version: 2

defaults: &defaults
working_directory: /tmp/project
docker:
- image: arcanemagus/atom-docker-ci:stable
steps:
# Restore project state
- attach_workspace:
at: /tmp
- run:
name: Install Node.js 10
command: |
sudo apt-get update && \
sudo apt-get install --assume-yes --quiet --no-install-suggests \
--no-install-recommends gnupg && \
curl -sL https://deb.nodesource.com/setup_10.x | sudo -E bash - && \
sudo apt-get update && \
sudo apt-get install --assume-yes --quiet --no-install-suggests \
--no-install-recommends nodejs
- run:
name: Node.js version
command: node --version
- run:
name: Install sass-lint globally
command: |
sudo npm install --global sass-lint && \
sudo rm -Rf ~/.npm
# Removes the .npm folder as the cache is partially polluted as root
- run:
name: Sass Lint version
command: sass-lint --version
- run:
name: Create VFB for Atom to run in
command: /usr/local/bin/xvfb_start
- run:
name: Atom version
command: ${ATOM_SCRIPT_PATH} --version
- run:
name: APM version
command: ${APM_SCRIPT_PATH} --version
- run:
name: Package APM package dependencies
command: |
if [ -n "${APM_TEST_PACKAGES}" ]; then
for pack in ${APM_TEST_PACKAGES}; do
${APM_SCRIPT_PATH} install "${pack}"
done
fi;
- run:
name: Package dependencies
command: ${APM_SCRIPT_PATH} install
- run:
name: Cleaning package
command: ${APM_SCRIPT_PATH} clean
- run:
name: Package specs
command: ${ATOM_SCRIPT_PATH} --test spec
# Cache node_modules
- save_cache:
paths:
- node_modules
key: v2-dependencies-{{ .Branch }}-{{ checksum "package.json" }}-{{ checksum "package-lock.json"}}

jobs:
checkout_code:
<<: *defaults
docker:
- image: circleci/node:latest
steps:
- checkout
# Restore node_modules from the last build
- restore_cache:
keys:
# Get latest cache for this package.json and pacakge-lock.json
- v2-dependencies-{{ .Branch }}-{{ checksum "package.json" }}-{{ checksum "package-lock.json"}}
# Fallback to the current package.json
- v2-dependencies-{{ .Branch }}-{{ checksum "package.json" }}-
# Fallback to the last build for this branch
- v2-dependencies-{{ .Branch }}-
# Fallback to the last available master branch cache
- v2-dependencies-master-
# Don't go further down to prevent dependency issues from other branches
# Save project state for next steps
- persist_to_workspace:
root: /tmp
paths:
- project
lint:
<<: *defaults
docker:
- image: circleci/node:latest
steps:
# Restore project state
- attach_workspace:
at: /tmp
- run:
name: Node.js Version
command: node --version
- run:
name: NPM Version
command: npm --version
- run:
name: Install any remaining dependencies
command: npm install
- run:
name: Lint code
command: npm run lint
stable:
<<: *defaults
beta:
<<: *defaults
docker:
- image: arcanemagus/atom-docker-ci:beta

workflows:
version: 2
test_package:
jobs:
- checkout_code
- lint:
requires:
- checkout_code
- stable:
requires:
- lint
- beta:
requires:
- lint
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ os:

# Installed for linting the project
language: node_js
node_js: "6"
node_js: "10"

install:
- npm install -g sass-lint
29 changes: 29 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,32 @@
# 1.9.0
- Update to linter v2 API

# 1.8.3
- Update sass-lint version to 1.12.1

# 1.8.2
- Update sass-lint version to 1.12.0
- Update dependencies

# 1.8.1
- apm publish issue - no such version

# 1.8.0
- Reworked the way that a config file is resolved to fix issues where configs in project roots were being ignored.
- Updated a few dependencies

# 1.7.6
- Update sass-lint version to 1.11.1

## 1.7.5
- Update sass-lint version to 1.11.0

## 1.7.4
- Update sass-lint version to 1.10.2

## 1.7.3
- Update sass-lint version to 1.10.1

## 1.7.2
- Update sass-lint version to 1.10.0 - adds support for disabling linters via comments
- Updated other third party packages
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@

* Pull requests should reference their related issues where possible. If the pull request closes an issue, [please reference its closing from a commit messages](https://help.github.com/articles/closing-issues-via-commit-messages/).
* Pull request titles should be descriptive, explaining at the high level what it is doing, and should be written in the same style as [Git commit messages](#git-commit-messages).
* Follow our Coffeescript styleguides. We have linters set up to catch most of it.
* Follow the current coding style. Your changes should pass `npm run lint`.
* Ensure that [EditorConfig](http://editorconfig.org/) installed in the editor and that it is functioning properly.
* Do not squash or rebase commits when submitting a Pull Request. It makes it much harder to follow work and make incremental changes.
* Ensure no Emoji tags are used in the title of the Pull Request
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ environment:

install:
# Install Node.js to run any configured linters
- ps: Install-Product node 6
- ps: Install-Product node 10
- npm install -g sass-lint

### Generic setup follows ###
13 changes: 0 additions & 13 deletions circle.yml

This file was deleted.

7 changes: 5 additions & 2 deletions lib/constants.coffee → lib/constants.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
module.exports =
'use babel';

export default {
SASSLINT_DOC_URL: 'https://github.com/sasstools/sass-lint/tree/master/docs/rules',
VALID_SYNTAXES: ['scss', 'sass']
VALID_SYNTAXES: ['scss', 'sass'],
};
35 changes: 0 additions & 35 deletions lib/helpers.coffee

This file was deleted.

Loading