Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated functions provided by AuthService plugin #295

Open
qifeng-bai opened this issue Nov 30, 2023 · 1 comment
Open

Replace deprecated functions provided by AuthService plugin #295

qifeng-bai opened this issue Nov 30, 2023 · 1 comment
Assignees
Milestone

Comments

@qifeng-bai
Copy link
Contributor

qifeng-bai commented Nov 30, 2023

1, Update userid based on username(email) of lists without userid

http://lists-test.ala.org.au/admin/updateListsWithUserIds

Issue: 1, Collect lists without userid, 2,Collection all registered users by calling authService.getAllUserNameMap() which is deprecated. 3, Iterate the returned lists, and find a userId in the returned users, then update records

Solution:
Given that it is an administrative function and there are not many lists without user IDs, it is acceptable to call the AuthService to retrieve user details one by one.

Testing:
Since we have to manually modify records in the database, we do not encourage testers to perform testing.

2, Update userid in Editor column.

We are not using 'editor' field in SpeciesList table. We are using 'Editor' table to store editors of a species list now
This function can be removed safely.

There is no records which editors field has value. The 'editors' field in SpeciesList can be removed safely.
-- The 'editors' field has been removed. Editor related function performs well

How to test:

Open any species list, add a known user email as editor in admin page. And Open again, if the new added email should be there

@qifeng-bai qifeng-bai self-assigned this Nov 30, 2023
qifeng-bai added a commit that referenced this issue Nov 30, 2023
@qifeng-bai
Copy link
Contributor Author

If there are records missing a user ID, you will see:

Screenshot 2023-11-30 at 11 24 11 am

@adam-collins adam-collins added this to the 5.2.0 milestone Jun 28, 2024
qifeng-bai added a commit that referenced this issue Jun 30, 2024
updates included in 5.2.0 snapshot
#292 Grails 6 upgrade
#295 Support the latest AuthService Plugin
#299 Fixed the broken list upload from Spatial
#302 Fixed download list csv issue
#306 Fixed 'family(matched)' facade
#288 Improved rematching process performance
qifeng-bai added a commit that referenced this issue Jun 30, 2024
Including updates from 5.2.1 snapshot

updates included in 5.2.0 snapshot
#292 Grails 6 upgrade
#295 Support the latest AuthService Plugin
#299 Fixed the broken list upload from Spatial
#302 Fixed download list csv issue
#306 Fixed 'family(matched)' facade
#288 Improved rematching process performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants