Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The return of Proboscidea #203

Open
charvolant opened this issue May 10, 2023 · 2 comments
Open

The return of Proboscidea #203

charvolant opened this issue May 10, 2023 · 2 comments
Labels

Comments

@charvolant
Copy link
Contributor

See https://lists.ala.org.au/speciesListItem/list/dr7933?q=Proboscidea

The result should match ALA_DR7933_1 and be excluded but instead matches https://biodiversity.org.au/afd/taxa/da144fb5-e7fa-4092-b442-6c505aef731f

@Sherrin-ALA
Copy link

It would appear that the issue here is a lack of higher taxonomy when comparing the matches. Names that are excluded do not get an accepted parent id in the LTC, so the Proboscidea document in the index doesn't have a value for kingdom, phylum, etc. Thus the match is downgraded.

Need to find out if there was a decision made not to place excluded names within the hierarchy, or if it's an bug

@Sherrin-ALA
Copy link

The commit "Merge remote-tracking branch 'upstream/develop' into issue-188" introduced the ability to determine if a parentID is added based on the status of the taxon entry. It appears that as a default, ParentIDs aren't added for "EXCLUDED" taxon entries.

Updated the entry for dr7933 in Ala-taxon-config.json to set ParentOutput for EXCLUDE to true -
{
"id" : "dr7933",
"name": "ALA",
"description": "Specific ALA fixes for various problems. These take precedence over anything else.",
"parent": "default",
"rightsHolder": "Atlas of Living Australia",
"licence": "CC-BY",
"defaultScore" : 10000,
"parentOutput": {
"EXCLUDED": true
}
},

On rebuilding the taxonomy, and rebuilding the index, the test now matches ALA_DR7933_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants