Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AstroBox don't listen when the printer has completely paused/resumed #297

Open
julianCast opened this issue Aug 31, 2017 · 0 comments
Open
Labels

Comments

@julianCast
Copy link
Collaborator

- Problem

If an user click pause button on a printing, and then quickly click resume, the printer may took some time to physically move its bed/extruder for the first command (pause), so its state will change again, but the command won't work. Thill will invert the pause/resume control.

- Fix Information
Now the printer don't send any event or change its state once is completely paused. Every printer take different time to finish moving its parts, but they may have an intern event due a bip sound some emit.

The ideal would be capture that event and wait for it before the websocket send the data changed, so the only change would be here in AstroBox, and anybody listening the socket would listen the paused/resume change once the printer is ready for real.

Note: This may be related to the extruder control behaviour, if an user click several times a direction button(for example:left), all the commands will be send, and acumulated.I think it shouldn't accept commands while its moving.

@julianCast julianCast added the bug label Aug 31, 2017
@julianCast julianCast changed the title AstroBox don't listen when the printer has finished some commands AstroBox don't listen when the printer has completely finished pausing/resuming Aug 31, 2017
@julianCast julianCast changed the title AstroBox don't listen when the printer has completely finished pausing/resuming AstroBox don't listen when the printer has completely paused/resumed Sep 1, 2017
@julianCast julianCast reopened this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant