Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize names of params in widget constructors that come from the same enum #33

Open
codingiswhyicry opened this issue Feb 11, 2022 · 1 comment
Labels
easy start for tickets / items that can be taken on by beginners enhancement New feature or request top priority stuff that is a blocker to launch v2 roadmap babey

Comments

@codingiswhyicry
Copy link
Contributor

(This is my fault sorry) - sometimes across constructors of widgets, named parameters will have different names even when they collect the same type of enum. This leads to developer confusion, and is a small thing that just improves readability and more.

Instead of:
SmolTextButtonElement(decorationVariant: decorationPriority.standard);
PrimaryIconButtonElement(variation: decorationPriority.standard);
StandardButtonElement(decor: decorationPriority.standard);

Have it be:
SmolTextButtonElement(decorationVariant: decorationPriority.standard);
PrimaryIconButtonElement(decorationVariant: decorationPriority.standard);
StandardButtonElement(decorationVariant: decorationPriority.standard);

@codingiswhyicry codingiswhyicry added the enhancement New feature or request label Feb 24, 2022
@codingiswhyicry codingiswhyicry added easy start for tickets / items that can be taken on by beginners top priority stuff that is a blocker to launch labels Feb 12, 2023
@codingiswhyicry
Copy link
Contributor Author

Adding top priority tag to this, as param name changes will be a breaking change. So, let's fix this prior to solidifying Aureus as out of beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy start for tickets / items that can be taken on by beginners enhancement New feature or request top priority stuff that is a blocker to launch v2 roadmap babey
Projects
None yet
Development

No branches or pull requests

1 participant