Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XVM error handling #1011

Merged
merged 9 commits into from
Aug 30, 2023
Merged

XVM error handling #1011

merged 9 commits into from
Aug 30, 2023

Conversation

shaunxw
Copy link
Member

@shaunxw shaunxw commented Aug 28, 2023

Pull Request Summary

  • Error and revert handling
  • Propagate error across VMs and runtime
  • Refactor XVM call error types
  • Added integration tests for error handling
  • Updated existing tests with error checks

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@shaunxw shaunxw added XVM Related to XVM shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. and removed shibuya related to shibuya labels Aug 28, 2023
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have a few questions.

primitives/src/xvm.rs Show resolved Hide resolved
tests/integration/src/xvm.rs Outdated Show resolved Hide resolved
tests/integration/src/setup.rs Show resolved Hide resolved
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/collator-selection/src 69% 0%
pallets/xc-asset-config/src 53% 0%
chain-extensions/types/dapps-staking/src 0% 0%
pallets/xvm/src 45% 0%
pallets/ethereum-checked/src 48% 0%
pallets/block-reward/src 85% 0%
chain-extensions/dapps-staking/src 0% 0%
precompiles/sr25519/src 79% 0%
precompiles/utils/src/testing 62% 0%
primitives/src 65% 0%
primitives/src/xcm 66% 0%
chain-extensions/xvm/src 0% 0%
pallets/contracts-migration/src 0% 0%
chain-extensions/pallet-assets/src 0% 0%
precompiles/assets-erc20/src 76% 0%
precompiles/dapps-staking/src 93% 0%
pallets/dapps-staking/src/pallet 85% 0%
precompiles/substrate-ecdsa/src 78% 0%
precompiles/utils/macro/src 0% 0%
precompiles/batch/src 80% 0%
chain-extensions/types/assets/src 0% 0%
pallets/dapps-staking/src 81% 0%
precompiles/utils/src 68% 0%
precompiles/xcm/src 84% 0%
chain-extensions/types/xvm/src 0% 0%
precompiles/xvm/src 80% 0%
pallets/custom-signatures/src 51% 0%
pallets/pallet-xcm/src 53% 0%
Summary 57% (2555 / 4466) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaunxw shaunxw merged commit ee95f5a into master Aug 30, 2023
12 checks passed
@shaunxw shaunxw deleted the feat/xvm-error-propagation branch August 30, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. XVM Related to XVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants