Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tier param setting call #1421

Merged
merged 10 commits into from
Feb 19, 2025
Merged

Tier param setting call #1421

merged 10 commits into from
Feb 19, 2025

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Feb 5, 2025 •
edited
Loading

Pull Request Summary

Adds set_static_tier_params extrinsic to modify tier related dApp staking parameters dynamically.
Requires root level privileges.

Additionally expands the TierParameters struct to allow changing of the weight values of the linear equation used to determine number of slots.

TODO

  • benchmarks
  • try-runtime testing

@Dinonard Dinonard added shiden related to shiden runtime astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya labels Feb 5, 2025
@Dinonard Dinonard marked this pull request as ready for review February 5, 2025 14:09
ipapandinas
ipapandinas reviewed Feb 13, 2025
View reviewed changes
pallets/dapp-staking/src/test/tests_types.rs Outdated Show resolved Hide resolved
pallets/dapp-staking/src/migration.rs Show resolved Hide resolved
pallets/dapp-staking/src/migration.rs Show resolved Hide resolved
runtime/shiden/src/lib.rs Show resolved Hide resolved
ipapandinas
ipapandinas previously approved these changes Feb 13, 2025
View reviewed changes
@Dinonard
Copy link
Member Author

I will merge this after move_stake is merged.

@Dinonard
Copy link
Member Author

/bench astar-dev,shibuya-dev,shiden-dev pallet_dapps_staking

@github-actions GitHub Actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/13395105740.
Please wait for a while.
Branch: feat/ds-tier-config-extrinsic
SHA: 027da52

@github-actions GitHub Actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/13395105740.

@Dinonard
Copy link
Member Author

/bench astar-dev,shibuya-dev,shiden-dev pallet_dapp_staking

@github-actions GitHub Actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/13407032835.
Please wait for a while.
Branch: feat/ds-tier-config-extrinsic
SHA: 027da52

@github-actions GitHub Actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/13407032835.

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/xcm/src 69% 0% ➖
pallets/dapp-staking/src/test 0% 0% ❌
pallets/price-aggregator/src 75% 0% ➖
pallets/unified-accounts/src 80% 0% ✔
pallets/xc-asset-config/src 48% 0% ❌
precompiles/dapp-staking/src 89% 0% ✔
pallets/inflation/src 90% 0% ✔
precompiles/dispatch-lockdrop/src 83% 0% ✔
precompiles/unified-accounts/src 100% 0% ✔
pallets/collator-selection/src 87% 0% ✔
chain-extensions/pallet-assets/src 54% 0% ➖
pallets/vesting-mbm/src 87% 0% ✔
precompiles/substrate-ecdsa/src 67% 0% ➖
pallets/dapp-staking/rpc/runtime-api/src 0% 0% ❌
chain-extensions/types/unified-accounts/src 0% 0% ❌
pallets/dapp-staking/src/benchmarking 96% 0% ✔
primitives/src 54% 0% ➖
precompiles/sr25519/src 56% 0% ➖
pallets/static-price-provider/src 91% 0% ✔
pallets/dynamic-evm-base-fee/src 82% 0% ✔
pallets/dapp-staking/src 78% 0% ➖
chain-extensions/types/assets/src 0% 0% ❌
pallets/ethereum-checked/src 76% 0% ➖
precompiles/assets-erc20/src 78% 0% ➖
pallets/collective-proxy/src 94% 0% ✔
precompiles/dapp-staking/src/test 0% 0% ❌
pallets/astar-xcm-benchmarks/src/fungible 100% 0% ✔
chain-extensions/unified-accounts/src 0% 0% ❌
pallets/astar-xcm-benchmarks/src/generic 100% 0% ✔
pallets/astar-xcm-benchmarks/src 86% 0% ✔
primitives/src/xcm 62% 0% ➖
Summary 75% (3704 / 4928) 0% (0 / 0) ➖

Minimum allowed line rate is 50%

@Dinonard Dinonard requested a review from ipapandinas February 19, 2025 08:26
ipapandinas
ipapandinas approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@ipapandinas ipapandinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard Dinonard requested a review from ermalkaleci February 19, 2025 14:14
ermalkaleci
ermalkaleci approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@ermalkaleci ermalkaleci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard Dinonard merged commit 8b238f8 into master Feb 19, 2025
11 checks passed
@Dinonard Dinonard deleted the feat/ds-tier-config-extrinsic branch February 19, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermalkaleci ermalkaleci ermalkaleci approved these changes

@ipapandinas ipapandinas ipapandinas approved these changes

@grbIzl grbIzl Awaiting requested review from grbIzl

Assignees
No one assigned
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dinonard @ermalkaleci @ipapandinas