FR: Add path() method to DirEntry

[netthier]

I noticed that russh_sftp::client::fs::DirEntry is missing a path() method which is provided in the std-equivalent.
Would it be possible to add one?

[AspectUnk]

Welcome! Implementing path() creates a path canonicalization issue, path() returns the full path, and the requested one can be relative. Is it required to do request to the server for canonize the path or do it locally? It is also worth considering the problems of local canonicalization because of which even standard canonicalization checks the path.

[AspectUnk]

@chipsenkbeil if it’s not difficult, what you think?

[chipsenkbeil]

@AspectUnk to my knowledge, std::fs::DirEntry::path() does not do any canonicalization or path resolution. Instead, it just prepends the path used to create the entry. This means that if you called read_dir with ./some/relative/path and the entry was file.txt, I would expect path() to return ./some/relative/path/file.txt.

Of course, the trick with the string is knowing what separator to use when joining them together. I do this by first executing and caching a call to the server to see if it's Windows using my homegrown is_windows function.

As for the return type, similar to my comments about using AsRef<Path>, I'd recommend either returning a String or a path abstraction that is separate from Rust's standard path.