Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with calculating the Training Loss #19

Open
sashkboos opened this issue Nov 18, 2020 · 3 comments
Open

Bug with calculating the Training Loss #19

sashkboos opened this issue Nov 18, 2020 · 3 comments

Comments

@sashkboos
Copy link

idxs=user_groups[idx], logger=logger)

Here, I think we have to replace the idx with c because we want to calculate the Training error of the global_model on all training data (after the averaging).

@heymyNLI
Copy link

I agree with sashkboos

@bigmoumou
Copy link

Agree. It should loop all the clients.

@wangclin
Copy link

of couse, it is a mistake apparently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants